[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 112157: replace deprecated widgets
From: "Commit Hook" <null () kde ! org>
Date: 2013-08-20 13:24:02
Message-ID: 20130820132402.21713.22323 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112157/
-----------------------------------------------------------
(Updated Aug. 20, 2013, 1:24 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Description
-------
Hello,
* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot)
Diffs
-----
engineexplorer/CMakeLists.txt 1466542
engineexplorer/engineexplorer.h 5c19fa6
engineexplorer/engineexplorer.cpp a3f2e1f
engineexplorer/engineexplorer.ui 65e70b4
engineexplorer/ktreeviewsearchline.cpp 734ef94
engineexplorer/main.cpp 8eae7a3
engineexplorer/serviceviewer.h dc0b36b
engineexplorer/serviceviewer.cpp d7e8e5a
engineexplorer/serviceviewer.ui b91b784
Diff: http://git.reviewboard.kde.org/r/112157/diff/
Testing
-------
it is building/installing/working correctly. I have noticed any issue
File Attachments
----------------
http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png
Thanks,
Giorgos Tsiapaliokas
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112157/">http://git.reviewboard.kde.org/r/112157/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2013, 1:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot) </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">it is building/installing/working correctly. I have noticed any \
issue</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>engineexplorer/CMakeLists.txt <span style="color: grey">(1466542)</span></li>
<li>engineexplorer/engineexplorer.h <span style="color: grey">(5c19fa6)</span></li>
<li>engineexplorer/engineexplorer.cpp <span style="color: \
grey">(a3f2e1f)</span></li>
<li>engineexplorer/engineexplorer.ui <span style="color: grey">(65e70b4)</span></li>
<li>engineexplorer/ktreeviewsearchline.cpp <span style="color: \
grey">(734ef94)</span></li>
<li>engineexplorer/main.cpp <span style="color: grey">(8eae7a3)</span></li>
<li>engineexplorer/serviceviewer.h <span style="color: grey">(dc0b36b)</span></li>
<li>engineexplorer/serviceviewer.cpp <span style="color: grey">(d7e8e5a)</span></li>
<li>engineexplorer/serviceviewer.ui <span style="color: grey">(b91b784)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112157/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png">layout.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic