From kde-panel-devel Tue Aug 20 13:24:02 2013 From: "Commit Hook" Date: Tue, 20 Aug 2013 13:24:02 +0000 To: kde-panel-devel Subject: Re: Review Request 112157: replace deprecated widgets Message-Id: <20130820132402.21713.22323 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=137700506325410 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0551563588411158671==" --===============0551563588411158671== Content-Type: multipart/alternative; boundary="===============1085694863086719063==" --===============1085694863086719063== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112157/ ----------------------------------------------------------- (Updated Aug. 20, 2013, 1:24 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Description ------- Hello, * this replaces the deprecated widgets from the plasmaengineexplorer * makes the serviceviewer.ui nicer( I have attached a screenshot) Diffs ----- engineexplorer/CMakeLists.txt 1466542 engineexplorer/engineexplorer.h 5c19fa6 engineexplorer/engineexplorer.cpp a3f2e1f engineexplorer/engineexplorer.ui 65e70b4 engineexplorer/ktreeviewsearchline.cpp 734ef94 engineexplorer/main.cpp 8eae7a3 engineexplorer/serviceviewer.h dc0b36b engineexplorer/serviceviewer.cpp d7e8e5a engineexplorer/serviceviewer.ui b91b784 Diff: http://git.reviewboard.kde.org/r/112157/diff/ Testing ------- it is building/installing/working correctly. I have noticed any issue File Attachments ---------------- http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png Thanks, Giorgos Tsiapaliokas --===============1085694863086719063== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112157/

This change has been marked as submitted.

Review request for Plasma.
By Giorgos Tsiapaliokas.

Updated Aug. 20, 2013, 1:24 p.m.

Description 

Hello,

* this replaces the deprecated widgets from the plasmaengineexplorer
* makes the serviceviewer.ui nicer( I have attached a screenshot)

Testing 

it is building/installing/working correctly. I have noticed any issue

Diffs

  • engineexplorer/CMakeLists.txt (1466542)
  • engineexplorer/engineexplorer.h (5c19fa6)
  • engineexplorer/engineexplorer.cpp (a3f2e1f)
  • engineexplorer/engineexplorer.ui (65e70b4)
  • engineexplorer/ktreeviewsearchline.cpp (734ef94)
  • engineexplorer/main.cpp (8eae7a3)
  • engineexplorer/serviceviewer.h (dc0b36b)
  • engineexplorer/serviceviewer.cpp (d7e8e5a)
  • engineexplorer/serviceviewer.ui (b91b784)

View Diff

File Attachments

--===============1085694863086719063==-- --===============0551563588411158671== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0551563588411158671==--