[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 110967: Icontasks: add an option to disable mouse wheel for task switching
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-06-13 13:55:16
Message-ID: 20130613135516.11564.60509 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 12, 2013, 8:49 a.m., Marco Martin wrote:
> > hm, this should be a global thing rather a config of a particular applet
>
> Luca Manganelli wrote:
> Right. The task-switching by scroll wheel affects the standard task bar panel, too.
>
> These two plasmoids (icontasks and the standard task bar panel) share the almost \
> same wheelEvent.
> Martin Gräßlin wrote:
> it's not just tasks, it's almost everything. Good example is the digital clock or \
> the pager. So I agree with Marco: this should be global.
> As I went through a lot of bug reports lately: many users have problems with it, so \
> I would vote for global option disabled by default.
Yep; in fact, if you see the bug report (which is probably 3 or more years old at \
this point!) I said exactly this -> it needs to be a global setting and go into the \
workspace behaviour control panel. I have rejected other patches for exactly this \
reason.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110967/#review34208
-----------------------------------------------------------
On June 12, 2013, 8:44 a.m., Luca Manganelli wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110967/
> -----------------------------------------------------------
>
> (Updated June 12, 2013, 8:44 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This patch adds a checkbox "Disable task switching with scroll wheel" in the \
> configuration dialog box (tab "Behaviour").
> Since it adds a new string, I think that this diff will not pushed before KDE 4.11, \
> right?
>
> This addresses bug 320523.
> http://bugs.kde.org/show_bug.cgi?id=320523
>
>
> Diffs
> -----
>
> applets/icontasks/behaviourconfig.ui ec0a9ba
> applets/icontasks/taskgroupitem.h a249391
> applets/icontasks/taskgroupitem.cpp cdc411f
> applets/icontasks/tasks.cpp a293564
>
> Diff: http://git.reviewboard.kde.org/r/110967/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Luca Manganelli
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110967/">http://git.reviewboard.kde.org/r/110967/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 12th, 2013, 8:49 a.m. UTC, <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">hm, this should be a global thing rather a config of a particular \
applet</pre> </blockquote>
<p>On June 12th, 2013, 9:42 a.m. UTC, <b>Luca Manganelli</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right. The \
task-switching by scroll wheel affects the standard task bar panel, too.
These two plasmoids (icontasks and the standard task bar panel) share the almost same \
wheelEvent.</pre> </blockquote>
<p>On June 12th, 2013, 9:48 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">it's not just tasks, \
it's almost everything. Good example is the digital clock or the pager. So I \
agree with Marco: this should be global.
As I went through a lot of bug reports lately: many users have problems with it, so I \
would vote for global option disabled by default.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep; in fact, if you see \
the bug report (which is probably 3 or more years old at this point!) I said exactly \
this -> it needs to be a global setting and go into the workspace behaviour \
control panel. I have rejected other patches for exactly this reason.</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On June 12th, 2013, 8:44 a.m. UTC, Luca Manganelli wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Luca Manganelli.</div>
<p style="color: grey;"><i>Updated June 12, 2013, 8:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds a checkbox "Disable task switching with scroll \
wheel" in the configuration dialog box (tab "Behaviour").
Since it adds a new string, I think that this diff will not pushed before KDE 4.11, \
right?</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=320523">320523</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/behaviourconfig.ui <span style="color: \
grey">(ec0a9ba)</span></li>
<li>applets/icontasks/taskgroupitem.h <span style="color: \
grey">(a249391)</span></li>
<li>applets/icontasks/taskgroupitem.cpp <span style="color: \
grey">(cdc411f)</span></li>
<li>applets/icontasks/tasks.cpp <span style="color: grey">(a293564)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110967/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic