This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110967/

On June 12th, 2013, 8:49 a.m. UTC, Marco Martin wrote:

hm, this should be a global thing rather a config of a particular applet

On June 12th, 2013, 9:42 a.m. UTC, Luca Manganelli wrote:

Right. The task-switching by scroll wheel affects the standard task bar panel, too.

These two plasmoids (icontasks and the standard task bar panel) share the almost same wheelEvent.

On June 12th, 2013, 9:48 a.m. UTC, Martin Gräßlin wrote:

it's not just tasks, it's almost everything. Good example is the digital clock or the pager. So I agree with Marco: this should be global.

As I went through a lot of bug reports lately: many users have problems with it, so I would vote for global option disabled by default.
Yep; in fact, if you see the bug report (which is probably 3 or more years old at this point!) I said exactly this -> it needs to be a global setting and go into the workspace behaviour control panel. I have rejected other patches for exactly this reason.

- Aaron J.


On June 12th, 2013, 8:44 a.m. UTC, Luca Manganelli wrote:

Review request for Plasma.
By Luca Manganelli.

Updated June 12, 2013, 8:44 a.m.

Description

This patch adds a checkbox "Disable task switching with scroll wheel" in the configuration dialog box (tab "Behaviour").

Since it adds a new string, I think that this diff will not pushed before KDE 4.11, right?
Bugs: 320523

Diffs

  • applets/icontasks/behaviourconfig.ui (ec0a9ba)
  • applets/icontasks/taskgroupitem.h (a249391)
  • applets/icontasks/taskgroupitem.cpp (cdc411f)
  • applets/icontasks/tasks.cpp (a293564)

View Diff