[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Battery Monitor revamp
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2013-05-28 9:20:16
Message-ID: 10080843.yNKymSf8n3 () freedom
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Tuesday, May 28, 2013 11:09:57 Kai Uwe Broulik wrote:
> > So I'm a +1 for this change. It will need to be kept backwards compat for
> > other themes in the code, but that's not hard to do.
> 
> if (fillElementSvg.hasElement("Fill10")) {
>   // use new more accurate method
> } else {
>   // fallback for other/older themes
> }
> 
> would be the approach for this, right?

yes; we've done this in other places in the past. it's a bit annoying, but so 
be it. good to drop a comment in place saying why it is this way.

note that hasElement is fast after the first svg usage since it is cached 
between runs and therefore does not require actually asking the svg itself 
each and every time.

-- 
Aaron J. Seigo
["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]