[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly
From:       "Shantanu Tushar" <shantanu () kde ! org>
Date:       2013-05-24 16:30:46
Message-ID: 20130524163046.29817.51196 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110629/#review33101
-----------------------------------------------------------



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/110629/#comment24463>

    there should be a newline after '{'



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/110629/#comment24464>

    missing indentation


- Shantanu Tushar


On May 24, 2013, 7:46 a.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110629/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 7:46 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Dimming the image when it is not viewed directly or more simply when it shows up in \
> background while navigating in the Plasma Media Center. 
> The existing minor problem was that when user views a picture in a slideshow and \
> then navigate to the main screen or one level up, the image is shown in the same \
> opacity as the original in the background which causes a little discomfort in \
> seeing the gallery and other written texts on screen. 
> 
> Diffs
> -----
> 
> shells/newshell/package/contents/ui/mediacenter.qml ef71938 
> 
> Diff: http://git.reviewboard.kde.org/r/110629/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
> 


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110629/">http://git.reviewboard.kde.org/r/110629/</a>
  </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/110629/diff/1/?file=146107#file146107line140" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shells/newshell/package/contents/ui/mediacenter.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">140</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="k">Keys.onEscapePressed:</span> <span class="p">{</span><span \
class="nx">mediaBrowser</span><span class="p">.</span><span \
class="nx">visible</span><span class="o">=</span><span \
class="kc">true</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">there \
should be a newline after &#39;{&#39;</pre> </div>
<br />

<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/110629/diff/1/?file=146107#file146107line141" \
style="color: black; font-weight: bold; text-decoration: \
underline;">shells/newshell/package/contents/ui/mediacenter.qml</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">141</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
<span class="nx">mediaImageViewer</span><span class="p">.</span><span \
class="nx">dimImage</span><span class="p">();</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">missing \
indentation</pre> </div>
<br />



<p>- Shantanu</p>


<br />
<p>On May 24th, 2013, 7:46 a.m. UTC, Akshay Ratan wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>


<p style="color: grey;"><i>Updated May 24, 2013, 7:46 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Dimming the image when it is not viewed directly or more simply when it \
shows up in background while navigating in the Plasma Media Center.

The existing minor problem was that when user views a picture in a slideshow and then \
navigate to the main screen or one level up, the image is shown in the same opacity \
as the original in the background which causes a little discomfort in seeing the \
gallery and other written texts on screen.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Works as intended.</pre>  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: \
grey">(ef71938)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110629/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>



_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic