From kde-panel-devel Fri May 24 16:30:46 2013 From: "Shantanu Tushar" Date: Fri, 24 May 2013 16:30:46 +0000 To: kde-panel-devel Subject: Re: Review Request 110629: Feature: Dimming the image when it is not viewed directly Message-Id: <20130524163046.29817.51196 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136941306513546 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6198362947719509809==" --===============6198362947719509809== Content-Type: multipart/alternative; boundary="===============5294248910531215098==" --===============5294248910531215098== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110629/#review33101 ----------------------------------------------------------- shells/newshell/package/contents/ui/mediacenter.qml there should be a newline after '{' shells/newshell/package/contents/ui/mediacenter.qml missing indentation - Shantanu Tushar On May 24, 2013, 7:46 a.m., Akshay Ratan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/110629/ > ----------------------------------------------------------- > > (Updated May 24, 2013, 7:46 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Description > ------- > > Dimming the image when it is not viewed directly or more simply when it shows up in background while navigating in the Plasma Media Center. > > The existing minor problem was that when user views a picture in a slideshow and then navigate to the main screen or one level up, the image is shown in the same opacity as the original in the background which causes a little discomfort in seeing the gallery and other written texts on screen. > > > Diffs > ----- > > shells/newshell/package/contents/ui/mediacenter.qml ef71938 > > Diff: http://git.reviewboard.kde.org/r/110629/diff/ > > > Testing > ------- > > Works as intended. > > > Thanks, > > Akshay Ratan > > --===============5294248910531215098== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110629/

shells/newshell/package/contents/ui/mediacenter.qml (Diff revision 1)
		140	Keys.onEscapePressed: {mediaBrowser.visible=true

there should be a newline after '{'

shells/newshell/package/contents/ui/mediacenter.qml (Diff revision 1)
		141	mediaImageViewer.dimImage();

missing indentation

- Shantanu

On May 24th, 2013, 7:46 a.m. UTC, Akshay Ratan wrote:

Review request for Plasma, Shantanu Tushar and Sinny Kumari.

By Akshay Ratan.

Updated May 24, 2013, 7:46 a.m.

Description

Dimming the image when it is not viewed directly or more simply when it shows up in background while navigating in the Plasma Media Center.

The existing minor problem was that when user views a picture in a slideshow and then navigate to the main screen or one level up, the image is shown in the same opacity as the original in the background which causes a little discomfort in seeing the gallery and other written texts on screen.

Testing

Works as intended.

Diffs

shells/newshell/package/contents/ui/mediacenter.qml (ef71938)

--===============5294248910531215098==-- --===============6198362947719509809== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6198362947719509809==--