'Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2013-04-24 18:51:16
Message-ID: 20130424185116.21356.40305 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107908/#review31508
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107908/
> -----------------------------------------------------------
> 
> (Updated Dec. 25, 2012, 2:43 p.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch disables the setCustomNotification while a button (close, next, back) is \
> pressed, to prevent popup re-shifting which seems to eat the clicked event. Problem \
> is more deep in Plasma but has been around since Plasma exists, so this should fix \
> it for the notifications. 
> 
> This addresses bug 311413.
> http://bugs.kde.org/show_bug.cgi?id=311413
> 
> 
> Diffs
> -----
> 
> plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b 
> 
> Diff: http://git.reviewboard.kde.org/r/107908/diff/
> 
> 
> Testing
> -------
> 
> kdialog --passivepopup "bla"
> click, closes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107908/">http://git.reviewboard.kde.org/r/107908/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Marco</p>

<br />
<p>On December 25th, 2012, 2:43 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Dec. 25, 2012, 2:43 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch disables the setCustomNotification while a button (close, \
next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked \
event. Problem is more deep in Plasma but has been around since Plasma exists, so \
this should fix it for the notifications.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">kdialog --passivepopup &quot;bla&quot; click, closes.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=311413">311413</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml <span \
style="color: grey">(e63526b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107908/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 