From kde-panel-devel Wed Apr 24 18:51:16 2013 From: "Marco Martin" Date: Wed, 24 Apr 2013 18:51:16 +0000 To: kde-panel-devel Subject: Re: Review Request 107908: Fix dismissing LastNotificationPopup often failing Message-Id: <20130424185116.21356.40305 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136682949922830 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============3794896080782691095==" --===============3794896080782691095== Content-Type: multipart/alternative; boundary="===============9048282246700460414==" --===============9048282246700460414== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/#review31508 ----------------------------------------------------------- Ship it! Ship It! - Marco Martin On Dec. 25, 2012, 2:43 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107908/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2012, 2:43 p.m.) > > > Review request for Plasma and Marco Martin. > > > Description > ------- > > This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event. > Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications. > > > This addresses bug 311413. > http://bugs.kde.org/show_bug.cgi?id=311413 > > > Diffs > ----- > > plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml e63526b > > Diff: http://git.reviewboard.kde.org/r/107908/diff/ > > > Testing > ------- > > kdialog --passivepopup "bla" > click, closes. > > > Thanks, > > Kai Uwe Broulik > > --===============9048282246700460414== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107908/

Ship it!

Ship It!

- Marco

On December 25th, 2012, 2:43 p.m. UTC, Kai Uwe Broulik wrote:

Review request for Plasma and Marco Martin.

By Kai Uwe Broulik.

Updated Dec. 25, 2012, 2:43 p.m.

Description

This patch disables the setCustomNotification while a button (close, next, back) is pressed, to prevent popup re-shifting which seems to eat the clicked event.
Problem is more deep in Plasma but has been around since Plasma exists, so this should fix it for the notifications.

Testing

kdialog --passivepopup "bla"
click, closes.

Bugs: 311413

Diffs

plasma/generic/applets/notifications/contents/ui/LastNotificationPopup.qml (e63526b)

View Diff

--===============9048282246700460414==-- --===============3794896080782691095== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============3794896080782691095==--