'Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data fro'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data fro
From:       "Xuetian Weng" <wengxt () gmail ! com>
Date:       2013-04-20 18:14:58
Message-ID: 20130420181458.26863.95933 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110065/
-----------------------------------------------------------

(Updated April 20, 2013, 6:14 p.m.)

Review request for Plasma and Marco Martin.

Changes
-------

great.. we can avoid the (potential) property binding problem by put data as function \
argument.

Description
-------

Current notifications will give quite a lot warning, since jobsSource.data[modelData] \
might be undefined in the first place.

And this can also cause label1NameText to be shown as "undefinded: " for a job, this \
can be reproduced when you do the job of copy a large folder to sftp, the label1 will \
be undefined when doing the folder creation.

Diffs (updated)
-----

  plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 

Diff: http://git.reviewboard.kde.org/r/110065/diff/

Testing
-------

all related warning is now suppressed, and undefined will not be shown in the same \
case.

Thanks,

Xuetian Weng

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110065/">http://git.reviewboard.kde.org/r/110065/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Marco Martin.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated April 20, 2013, 6:14 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">great.. we can avoid the (potential) property binding problem by put \
data as function argument.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current notifications will give quite a lot warning, since \
jobsSource.data[modelData] might be undefined in the first place.

And this can also cause label1NameText to be shown as &quot;undefinded: &quot; for a \
job, this can be reproduced when you do the job of copy a large folder to sftp, the \
label1 will be undefined when doing the folder creation.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">all related warning is now suppressed, and undefined will not be shown \
in the same case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/notifications/contents/ui/JobDelegate.qml <span \
style="color: grey">(cf60946)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110065/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 