From kde-panel-devel Sat Apr 20 18:14:58 2013 From: "Xuetian Weng" Date: Sat, 20 Apr 2013 18:14:58 +0000 To: kde-panel-devel Subject: Re: Review Request 110065: fix notifcation plasmoid about some undefined data when retreive data fro Message-Id: <20130420181458.26863.95933 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136648172419699 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8472372686188314178==" --===============8472372686188314178== Content-Type: multipart/alternative; boundary="===============5891646467460100844==" --===============5891646467460100844== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/ ----------------------------------------------------------- (Updated April 20, 2013, 6:14 p.m.) Review request for Plasma and Marco Martin. Changes ------- great.. we can avoid the (potential) property binding problem by put data as function argument. Description ------- Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place. And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation. Diffs (updated) ----- plasma/generic/applets/notifications/contents/ui/JobDelegate.qml cf60946 Diff: http://git.reviewboard.kde.org/r/110065/diff/ Testing ------- all related warning is now suppressed, and undefined will not be shown in the same case. Thanks, Xuetian Weng --===============5891646467460100844== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110065/

Review request for Plasma and Marco Martin.

By Xuetian Weng.

Updated April 20, 2013, 6:14 p.m.

Changes

great.. we can avoid the (potential) property binding problem by put data as function argument.

Description

Current notifications will give quite a lot warning, since jobsSource.data[modelData] might be undefined in the first place.

And this can also cause label1NameText to be shown as "undefinded: " for a job, this can be reproduced when you do the job of copy a large folder to sftp, the label1 will be undefined when doing the folder creation.

Testing

all related warning is now suppressed, and undefined will not be shown in the same case.

Diffs (updated)

plasma/generic/applets/notifications/contents/ui/JobDelegate.qml (cf60946)

View Diff

--===============5891646467460100844==-- --===============8472372686188314178== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============8472372686188314178==--