'Re: Review Request 109709: Store idle timeouts in the correct units'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 109709: Store idle timeouts in the correct units
From:       "Oliver Henshaw" <oliver.henshaw () gmail ! com>
Date:       2013-03-25 19:17:26
Message-ID: 20130325191726.4551.78092 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109709/
-----------------------------------------------------------

(Updated March 25, 2013, 7:17 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Description
-------

[1/2] DPMS idle timeouts are stored in seconds

Meant that screen power-saving was probably never activated.

BUG: 310506
CCBUG: 304877

[2/2] Suspend idle timeouts are stored in milliseconds

Was storing in centiseconds(?) and in seconds in one place.

Meant that suspend was activated much too soon. Suspend timeouts are
currently commented out due this problem but should work properly when
or if they are re-enabled.

BUG: 310506
CCBUG: 304877

Diffs
-----

  applications/settings/modules/powermanagement/contents/ui/Power.qml \
c946990c8b89bf070fc830a74505b1e417850181 

Diff: http://git.reviewboard.kde.org/r/109709/diff/

Testing
-------

None. Don't currently have a testable plasma active VM. Only the dpms timeouts need \
testing since the suspend timeouts are in a commented out section.

May need to test target devices in case DPMS breaks on that hardware.

Thanks,

Oliver Henshaw

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/109709/">http://git.reviewboard.kde.org/r/109709/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Oliver Henshaw.</div>

<p style="color: grey;"><i>Updated March 25, 2013, 7:17 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">[1/2] DPMS idle timeouts are stored in seconds

Meant that screen power-saving was probably never activated.

BUG: 310506
CCBUG: 304877

[2/2] Suspend idle timeouts are stored in milliseconds

Was storing in centiseconds(?) and in seconds in one place.

Meant that suspend was activated much too soon. Suspend timeouts are
currently commented out due this problem but should work properly when
or if they are re-enabled.

BUG: 310506
CCBUG: 304877</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">None. Don&#39;t currently have a testable plasma active VM. Only the \
dpms timeouts need testing since the suspend timeouts are in a commented out section.

May need to test target devices in case DPMS breaks on that hardware.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applications/settings/modules/powermanagement/contents/ui/Power.qml <span \
style="color: grey">(c946990c8b89bf070fc830a74505b1e417850181)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/109709/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 