From kde-panel-devel Mon Mar 25 19:17:26 2013 From: "Oliver Henshaw" Date: Mon, 25 Mar 2013 19:17:26 +0000 To: kde-panel-devel Subject: Re: Review Request 109709: Store idle timeouts in the correct units Message-Id: <20130325191726.4551.78092 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=136423906521327 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1940116601025783473==" --===============1940116601025783473== Content-Type: multipart/alternative; boundary="===============5446365042767716360==" --===============5446365042767716360== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109709/ ----------------------------------------------------------- (Updated March 25, 2013, 7:17 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Description ------- [1/2] DPMS idle timeouts are stored in seconds Meant that screen power-saving was probably never activated. BUG: 310506 CCBUG: 304877 [2/2] Suspend idle timeouts are stored in milliseconds Was storing in centiseconds(?) and in seconds in one place. Meant that suspend was activated much too soon. Suspend timeouts are currently commented out due this problem but should work properly when or if they are re-enabled. BUG: 310506 CCBUG: 304877 Diffs ----- applications/settings/modules/powermanagement/contents/ui/Power.qml c946990c8b89bf070fc830a74505b1e417850181 Diff: http://git.reviewboard.kde.org/r/109709/diff/ Testing ------- None. Don't currently have a testable plasma active VM. Only the dpms timeouts need testing since the suspend timeouts are in a commented out section. May need to test target devices in case DPMS breaks on that hardware. Thanks, Oliver Henshaw --===============5446365042767716360== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109709/

This change has been marked as submitted.

Review request for Plasma.
By Oliver Henshaw.

Updated March 25, 2013, 7:17 p.m.

Description 

[1/2] DPMS idle timeouts are stored in seconds

Meant that screen power-saving was probably never activated.

BUG: 310506
CCBUG: 304877


[2/2] Suspend idle timeouts are stored in milliseconds

Was storing in centiseconds(?) and in seconds in one place.

Meant that suspend was activated much too soon. Suspend timeouts are
currently commented out due this problem but should work properly when
or if they are re-enabled.

BUG: 310506
CCBUG: 304877

Testing 

None. Don't currently have a testable plasma active VM. Only the dpms timeouts need testing since the suspend timeouts are in a commented out section.

May need to test target devices in case DPMS breaks on that hardware.

Diffs

  • applications/settings/modules/powermanagement/contents/ui/Power.qml (c946990c8b89bf070fc830a74505b1e417850181)

View Diff
--===============5446365042767716360==-- --===============1940116601025783473== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============1940116601025783473==--