[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109595: active-welcome plasmoid: use plasmacomponents ToolButton
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2013-03-20 14:27:49
Message-ID: 20130320142749.14838.25088 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109595/#review29559
-----------------------------------------------------------
I've noted two small issues in the review, whitespace and high-dpi compatibility.
applets/active-welcome/contents/code/welcome.qml
<http://git.reviewboard.kde.org/r/109595/#comment22050>
whitespace. Don't leave trailing spaces on empty lines.
Kate (and kwrite and kdevelop) have options to shorten empty lines, please use \
these. At least KDevelop can be setup so it only removes trailing spaces from lines \
you've actually changed, so you don't mess up your diff with a lot of whitespace \
changes that have been done automatically by your editor.
applets/active-welcome/contents/code/welcome.qml
<http://git.reviewboard.kde.org/r/109595/#comment22049>
Please use theme.iconSizes.desktop here, hardcoded values will cause highdpi \
issues.
- Sebastian Kügler
On March 19, 2013, 11:08 p.m., Michael Bohlender wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109595/
> -----------------------------------------------------------
>
> (Updated March 19, 2013, 11:08 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Replace ?mobilecomponents?.IconButton with PlasmaComponents.ToolButton
>
> I estimated the button size. they might seem visually smaller but the surface you \
> can hit to trigger should be about the same.
> This is my fist patch to Plasma Active.
> I did not subscribe to the plasma list when I first tried to submit this to \
> reviewboard. So sorry for the spam if this comes through twice.
>
>
> Diffs
> -----
>
> applets/active-welcome/contents/code/welcome.qml cf49d2f
>
> Diff: http://git.reviewboard.kde.org/r/109595/diff/
>
>
> Testing
> -------
>
> build + installed with kdesrc-build. viewed with plasmoidviewer
>
> could not test the video playback as that didn't work before either.
>
>
> Thanks,
>
> Michael Bohlender
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109595/">http://git.reviewboard.kde.org/r/109595/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've noted two small \
issues in the review, whitespace and high-dpi compatibility.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109595/diff/1/?file=120412#file120412line63" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/active-welcome/contents/code/welcome.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">62</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">icon:</span> <span class="nx">QIcon</span><span class="p">(</span><span \
class="s2">"go-previous"</span><span class="p">)</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">61</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">whitespace. \
Don't leave trailing spaces on empty lines.
Kate (and kwrite and kdevelop) have options to shorten empty lines, please use these. \
At least KDevelop can be setup so it only removes trailing spaces from lines \
you've actually changed, so you don't mess up your diff with a lot of \
whitespace changes that have been done automatically by your editor.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109595/diff/1/?file=120412#file120412line68" \
style="color: black; font-weight: bold; text-decoration: \
underline;">applets/active-welcome/contents/code/welcome.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">width:</span> <span class="mi">65</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please use \
theme.iconSizes.desktop here, hardcoded values will cause highdpi issues.</pre> \
</div> <br />
<p>- Sebastian</p>
<br />
<p>On March 19th, 2013, 11:08 p.m. UTC, Michael Bohlender wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Michael Bohlender.</div>
<p style="color: grey;"><i>Updated March 19, 2013, 11:08 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Replace ?mobilecomponents?.IconButton with PlasmaComponents.ToolButton
I estimated the button size. they might seem visually smaller but the surface you can \
hit to trigger should be about the same.
This is my fist patch to Plasma Active.
I did not subscribe to the plasma list when I first tried to submit this to \
reviewboard. So sorry for the spam if this comes through twice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">build + installed with kdesrc-build. viewed with plasmoidviewer
could not test the video playback as that didn't work before either.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/active-welcome/contents/code/welcome.qml <span style="color: \
grey">(cf49d2f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109595/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic