[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109492: Allow Rich Text in QML notifications plasmoid
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-03-20 14:20:18
Message-ID: 20130320142018.14081.58120 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109492/#review29558
-----------------------------------------------------------
Ship it!
I'm ok with this, though I have two reservations:
* other notification systems do not support rich text
* we should probably define a subset of rich text that is guaranteed to be supported
- Aaron J. Seigo
On March 17, 2013, 10:22 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109492/
> -----------------------------------------------------------
>
> (Updated March 17, 2013, 10:22 p.m.)
>
>
> Review request for kde-workspace, Plasma and Telepathy.
>
>
> Description
> -------
>
> Allow Rich Text in QML Notification plasmoid
>
> This matches behaviour of the notifications in 4.9 which used QLabel
> It fixes a problem we noticed in KTp in which we would see notifications with \
> > in the body as we deliberately try and keep formatting the same and be \
> HTML safe.
> I want to backport this to 4.10 branch
>
>
> Diffs
> -----
>
> plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
> ed8ed99f92b7b5e7c2b491bd8d13d3eadb3d65db
> Diff: http://git.reviewboard.kde.org/r/109492/diff/
>
>
> Testing
> -------
>
> Emitted notifications which were known to trigger the bug.
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109492/">http://git.reviewboard.kde.org/r/109492/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm ok with this, \
though I have two reservations:
* other notification systems do not support rich text
* we should probably define a subset of rich text that is guaranteed to be \
supported</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On March 17th, 2013, 10:22 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kde-workspace, Plasma and Telepathy.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated March 17, 2013, 10:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allow Rich Text in QML Notification plasmoid
This matches behaviour of the notifications in 4.9 which used QLabel
It fixes a problem we noticed in KTp in which we would see notifications with \
&nbsp; > in the body as we deliberately try and keep formatting the same and \
be HTML safe.
I want to backport this to 4.10 branch</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Emitted notifications which were known to trigger the bug.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/notifications/contents/ui/NotificationDelegate/NotificationDelegate.qml \
<span style="color: grey">(ed8ed99f92b7b5e7c2b491bd8d13d3eadb3d65db)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109492/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic