[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109340: Use default background colours for the konsolepreviewer
From: "Tianyu Zhu" <tian.tian098 () gmail ! com>
Date: 2013-03-11 13:31:49
Message-ID: 20130311133149.29742.61325 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/
-----------------------------------------------------------
(Updated March 11, 2013, 1:31 p.m.)
Review request for Plasma.
Changes
-------
Use QTextEdit instead of KTextEdit, since its background colour makes text more \
visible on light and dark themes when read-only is enabled.
Description
-------
- Deleted lines hard-coding the background of the konsolepreviwer to white.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274.
http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274
Diffs (updated)
-----
plasmate/konsole/konsolepreviewer.h 543ff77
plasmate/konsole/konsolepreviewer.cpp 05d426e
Diff: http://git.reviewboard.kde.org/r/109340/diff/
Testing
-------
Tested on Kubuntu 12.10 with KDE 4.10.1
Tested with both the default and Krita-Dark colour scheme. In both cases, the text in \
the konsolepreviewer shows up well against its background.
Thanks,
Tianyu Zhu
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109340/">http://git.reviewboard.kde.org/r/109340/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Tianyu Zhu.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 1:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use QTextEdit instead of KTextEdit, since its background colour makes \
text more visible on light and dark themes when read-only is enabled.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Deleted lines hard-coding the background of the konsolepreviwer to \
white.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on Kubuntu 12.10 with KDE 4.10.1 Tested with both the default and \
Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up \
well against its background.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274">https://bugs.kde.org/show_bug.cgi?id=316274</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/konsole/konsolepreviewer.h <span style="color: \
grey">(543ff77)</span></li>
<li>plasmate/konsole/konsolepreviewer.cpp <span style="color: \
grey">(05d426e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109340/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic