[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109340: Use default background colours for the konsolepreviewer
From: "Giorgos Tsiapaliokas" <terietor () gmail ! com>
Date: 2013-03-11 9:31:59
Message-ID: 20130311093159.24139.71208 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/#review28948
-----------------------------------------------------------
plasmate/konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/109340/#comment21647>
this code is correct, the background
color shouldn't be hardcoded.
But the konsolewidget isn't very readable without it.
http://paste.opensuse.org/30220251
The best solution is
* to remove the hardcoded
background
* s/KTextEdit/QTextEdit
QTextEdit is white in light themes and darker on the black ones
- Giorgos Tsiapaliokas
On March 7, 2013, 3:30 p.m., Tianyu Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109340/
> -----------------------------------------------------------
>
> (Updated March 7, 2013, 3:30 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> - Deleted lines hard-coding the background of the konsolepreviwer to white.
>
>
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274.
> http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274
>
>
> Diffs
> -----
>
> plasmate/konsole/konsolepreviewer.cpp 05d426e
>
> Diff: http://git.reviewboard.kde.org/r/109340/diff/
>
>
> Testing
> -------
>
> Tested on Kubuntu 12.10 with KDE 4.10.1
> Tested with both the default and Krita-Dark colour scheme. In both cases, the text \
> in the konsolepreviewer shows up well against its background.
>
> Thanks,
>
> Tianyu Zhu
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109340/">http://git.reviewboard.kde.org/r/109340/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109340/diff/1/?file=117785#file117785line48" \
style="color: black; font-weight: bold; text-decoration: \
underline;">plasmate/konsole/konsolepreviewer.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KonsolePreviewer::KonsolePreviewer(const QString & title, QWidget \
*parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">48</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1">//make \
the background white</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">49</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">QPalette</span> <span class="n">p</span> <span class="o">=</span> <span \
class="n">m_textEdit</span><span class="o">-></span><span \
class="n">palette</span><span class="p">();</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">50</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">p</span><span class="p">.</span><span class="n">setColor</span><span \
class="p">(</span><span class="n">QPalette</span><span class="o">::</span><span \
class="n">Base</span><span class="p">,</span> <span class="n">Qt</span><span \
class="o">::</span><span class="n">white</span><span class="p">);</span></pre></td> \
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">51</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_textEdit</span><span class="o">-></span><span \
class="n">setPalette</span><span class="p">(</span><span class="n">p</span><span \
class="p">);</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">this code \
is correct, the background color shouldn't be hardcoded.
But the konsolewidget isn't very readable without it.
http://paste.opensuse.org/30220251
The best solution is
* to remove the hardcoded
background
* s/KTextEdit/QTextEdit
QTextEdit is white in light themes and darker on the black ones
</pre>
</div>
<br />
<p>- Giorgos</p>
<br />
<p>On March 7th, 2013, 3:30 p.m. UTC, Tianyu Zhu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Tianyu Zhu.</div>
<p style="color: grey;"><i>Updated March 7, 2013, 3:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- Deleted lines hard-coding the background of the konsolepreviwer to \
white.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on Kubuntu 12.10 with KDE 4.10.1 Tested with both the default and \
Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up \
well against its background.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274">https://bugs.kde.org/show_bug.cgi?id=316274</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/konsole/konsolepreviewer.cpp <span style="color: \
grey">(05d426e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109340/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic