[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 109124: qml port currentappcontrol
From: "Greg T" <yellowcake- () gmx ! net>
Date: 2013-02-28 13:59:40
Message-ID: 20130228135940.25625.46991 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 26, 2013, 1:36 p.m., Aaron J. Seigo wrote:
> > - If you click on the title on the task bar, it doesn't show the kwin present \
> > windows effect, how to implement that? Is there interest in a 'kwin dataengine' \
> > or should I go for a mixed C++/QML applet?
> > a WindowSystem qml import would probably be the trick here, and it should be \
> > designed with the kwin team.
> > - there is an annoyance in the task list(present windows fallback): I can set a \
> > minimum height, but if I close a task and re-set the minimum height, the popup \
> > won't shrink again, leaving an unpleasant empty space; plasma bug?
> > as other users of this do shrink, my guess without looking would be that it is a \
> > QML issue and the item is not actually getting resized.
> > - the close/restore buttons don't glow on hover. I couldn't load a theme svg \
> > using the IconItem. Is that possible?
> > you can load an icon file from the svg theme and specify the element to use, \
> > e.g.: "source: svgname-elementname"
> > - do you know how to read the size of the containment the widget is contained?
> >
> > no, and this should never be required.
>
> Greg T wrote:
> - - there is an annoyance in the task list(present windows fallback): I can set a \
> minimum height, but if I close a task and re-set the minimum height, the popup \
> won't shrink again, leaving an unpleasant empty space; plasma bug?
> - as other users of this do shrink, my guess without looking would be that it is a \
> QML issue and the item is not actually getting resized.
> I've checked my qml code with a onMinimumHeightChanged handler and the size is set \
> correctly. Well, now I've set maximumHeight to minimumHeight. That does the trick!
> - you can load an icon file from the svg theme and specify the element to use, \
> e.g.: "source: svgname-elementname"
> After checking IconItem source, I don't even begin to understand how that can work. \
> First of all it splits for '-' and would try to load 'widgets/configuration' which \
> doesn't even exist
> i.e.: source: "widgets/configuration-icons-maximize"
>
> - - do you know how to read the size of the containment the widget is contained?
> - no, and this should never be required.
>
> sorry for providing insufficient data, but how would you implement this:
> const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 + fm.width('M')*30), \
> containment()->size().width()/4); on small screens the compactRepresentation of \
> currentappcontrol shouldn't take the whole panel width
> Kai Uwe Broulik wrote:
> Concerning the svg stuff, load the SVG like so:
> PlasmaCore.Svg {
> id: configurationIconsSvg
> imagePath: "widgets/configuration-icons"
> }
> and then you can use
> svg: configurationIconsSvg
> elementId: "maximize"
> to access it
that's right, I'm doing this right now. You can even write it more compact:
PlasmaCore.SvgItem {
anchors.fill: parent
elementId: "maximize"
svg: PlasmaCore.Svg {
imagePath: "widgets/configuration-icons"
}
}
What's your point?
- Greg
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109124/#review28133
-----------------------------------------------------------
On Feb. 25, 2013, 6:20 p.m., Greg T wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109124/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2013, 6:20 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Heya folks,
> This is a qml port of the netbook applet currentappcontrol. It's ready to use, but \
> not fully complete. Missing features/bugs:
> - If you click on the title on the task bar, it doesn't show the kwin present \
> windows effect, how to implement that? Is there interest in a 'kwin dataengine' or \
> should I go for a mixed C++/QML applet?
> - there is an annoyance in the task list(present windows fallback): I can set a \
> minimum height, but if I close a task and re-set the minimum height, the popup \
> won't shrink again, leaving an unpleasant empty space; plasma bug?
> - the close/restore buttons don't glow on hover. I couldn't load a theme svg using \
> the IconItem. Is that possible?
> - do you know how to read the size of the containment the widget is contained?
>
>
> Diffs
> -----
>
> CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857
> plasma/netbook/applets/currentappcontrol/CMakeLists.txt \
> 46178ce3a9351845855e9fccfbc13a9d3946fc95 \
> plasma/netbook/applets/currentappcontrol/Messages.sh \
> 45d44681ae1be43b2d71ca48ab3e77af37ad8861 \
> plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION \
> plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION \
> plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION
> Diff: http://git.reviewboard.kde.org/r/109124/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg T
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109124/">http://git.reviewboard.kde.org/r/109124/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 26th, 2013, 1:36 p.m. UTC, <b>Aaron J. \
Seigo</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">- If you click on the title on the task bar, it doesn't show the \
kwin present windows effect, how to implement that? Is there interest in a 'kwin \
dataengine' or should I go for a mixed C++/QML applet?
a WindowSystem qml import would probably be the trick here, and it should be designed \
with the kwin team.
- there is an annoyance in the task list(present windows fallback): I can set a \
minimum height, but if I close a task and re-set the minimum height, the popup \
won't shrink again, leaving an unpleasant empty space; plasma bug?
as other users of this do shrink, my guess without looking would be that it is a QML \
issue and the item is not actually getting resized.
- the close/restore buttons don't glow on hover. I couldn't load a theme svg \
using the IconItem. Is that possible?
you can load an icon file from the svg theme and specify the element to use, e.g.: \
"source: svgname-elementname"
- do you know how to read the size of the containment the widget is contained?
no, and this should never be required.</pre>
</blockquote>
<p>On February 28th, 2013, 10:58 a.m. UTC, <b>Greg T</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- - there is an \
annoyance in the task list(present windows fallback): I can set a minimum height, but \
if I close a task and re-set the minimum height, the popup won't shrink again, \
leaving an unpleasant empty space; plasma bug?
- as other users of this do shrink, my guess without looking would be that it is a \
QML issue and the item is not actually getting resized.
I've checked my qml code with a onMinimumHeightChanged handler and the size is \
set correctly. Well, now I've set maximumHeight to minimumHeight. That does the \
trick!
- you can load an icon file from the svg theme and specify the element to use, e.g.: \
"source: svgname-elementname"
After checking IconItem source, I don't even begin to understand how that can \
work. First of all it splits for '-' and would try to load \
'widgets/configuration' which doesn't even exist
i.e.: source: "widgets/configuration-icons-maximize"
- - do you know how to read the size of the containment the widget is contained?
- no, and this should never be required.
sorry for providing insufficient data, but how would you implement this:
const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 + \
fm.width('M')*30), containment()->size().width()/4); on small screens the \
compactRepresentation of currentappcontrol shouldn't take the whole panel \
width</pre> </blockquote>
<p>On February 28th, 2013, 1:07 p.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Concerning the svg \
stuff, load the SVG like so: PlasmaCore.Svg {
id: configurationIconsSvg
imagePath: "widgets/configuration-icons"
}
and then you can use
svg: configurationIconsSvg
elementId: "maximize"
to access it</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">that's right, \
I'm doing this right now. You can even write it more compact: PlasmaCore.SvgItem \
{ anchors.fill: parent
elementId: "maximize"
svg: PlasmaCore.Svg {
imagePath: "widgets/configuration-icons"
}
}
What's your point?</pre>
<br />
<p>- Greg</p>
<br />
<p>On February 25th, 2013, 6:20 p.m. UTC, Greg T wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Greg T.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2013, 6:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Heya folks, This is a qml port of the netbook applet currentappcontrol. \
It's ready to use, but not fully complete. Missing features/bugs:
- If you click on the title on the task bar, it doesn't show the kwin present \
windows effect, how to implement that? Is there interest in a 'kwin \
dataengine' or should I go for a mixed C++/QML applet?
- there is an annoyance in the task list(present windows fallback): I can set a \
minimum height, but if I close a task and re-set the minimum height, the popup \
won't shrink again, leaving an unpleasant empty space; plasma \
bug?
- the close/restore buttons don't glow on hover. I couldn't load a theme svg \
using the IconItem. Is that possible?
- do you know how to read the size of the containment the widget is contained?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(6084d7dd7655372506e02abe9f141b73155c5857)</span></li>
<li>plasma/netbook/applets/currentappcontrol/CMakeLists.txt <span style="color: \
grey">(46178ce3a9351845855e9fccfbc13a9d3946fc95)</span></li>
<li>plasma/netbook/applets/currentappcontrol/Messages.sh <span style="color: \
grey">(45d44681ae1be43b2d71ca48ab3e77af37ad8861)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/contents/ui/Task.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/netbook/applets/currentappcontrol/package/metadata.desktop <span \
style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109124/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic