This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/ |
On February 26th, 2013, 1:36 p.m. UTC, Aaron J. Seigo wrote:
- If you click on the title on the task bar, it doesn't show the kwin present windows effect, how to implement that? Is there interest in a 'kwin dataengine' or should I go for a mixed C++/QML applet? a WindowSystem qml import would probably be the trick here, and it should be designed with the kwin team. - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? as other users of this do shrink, my guess without looking would be that it is a QML issue and the item is not actually getting resized. - the close/restore buttons don't glow on hover. I couldn't load a theme svg using the IconItem. Is that possible? you can load an icon file from the svg theme and specify the element to use, e.g.: "source: svgname-elementname" - do you know how to read the size of the containment the widget is contained? no, and this should never be required.On February 28th, 2013, 10:58 a.m. UTC, Greg T wrote:
- - there is an annoyance in the task list(present windows fallback): I can set a minimum height, but if I close a task and re-set the minimum height, the popup won't shrink again, leaving an unpleasant empty space; plasma bug? - as other users of this do shrink, my guess without looking would be that it is a QML issue and the item is not actually getting resized. I've checked my qml code with a onMinimumHeightChanged handler and the size is set correctly. Well, now I've set maximumHeight to minimumHeight. That does the trick! - you can load an icon file from the svg theme and specify the element to use, e.g.: "source: svgname-elementname" After checking IconItem source, I don't even begin to understand how that can work. First of all it splits for '-' and would try to load 'widgets/configuration' which doesn't even exist i.e.: source: "widgets/configuration-icons-maximize" - - do you know how to read the size of the containment the widget is contained? - no, and this should never be required. sorry for providing insufficient data, but how would you implement this: const int width = qMin((qreal)(KIconLoader::SizeSmallMedium*2 + fm.width('M')*30), containment()->size().width()/4); on small screens the compactRepresentation of currentappcontrol shouldn't take the whole panel widthOn February 28th, 2013, 1:07 p.m. UTC, Kai Uwe Broulik wrote:
Concerning the svg stuff, load the SVG like so: PlasmaCore.Svg { id: configurationIconsSvg imagePath: "widgets/configuration-icons" } and then you can use svg: configurationIconsSvg elementId: "maximize" to access it
that's right, I'm doing this right now. You can even write it more compact: PlasmaCore.SvgItem { anchors.fill: parent elementId: "maximize" svg: PlasmaCore.Svg { imagePath: "widgets/configuration-icons" } } What's your point?
- Greg
On February 25th, 2013, 6:20 p.m. UTC, Greg T wrote:
Review request for Plasma.
By Greg T.
Updated Feb. 25, 2013, 6:20 p.m. Description
Diffs
|