'Re: Review Request 108922: Fix off-by-one error in RunnerModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108922: Fix off-by-one error in RunnerModel
From:       "Aleix Pol Gonzalez" <aleixpol () gmail ! com>
Date:       2013-02-15 12:32:04
Message-ID: 20130215123204.23724.82845 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108922/#review27508
-----------------------------------------------------------

Ship it!

It seems correct to me. It would be interesting if you could run some interesting \
session with the ModelTest to catch this kind of issues ASAP, no? :)

- Aleix Pol Gonzalez

On Feb. 12, 2013, 3:10 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108922/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2013, 3:10 p.m.)
> 
> 
> Review request for Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Fix off-by-one error in RunnerModel
> 
> The last argument of beginInsertRows() is the row number of the last
> inserted row, not the one for the row after.
> 
> 
> Diffs
> -----
> 
> plasma/declarativeimports/core/runnermodel.cpp \
> ee1b54d45e02f1db8650219e08f6950d0e732a85  
> Diff: http://git.reviewboard.kde.org/r/108922/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108922/">http://git.reviewboard.kde.org/r/108922/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems correct to me. \
It would be interesting if you could run some interesting session with the ModelTest \
to catch this kind of issues ASAP, no? :)</pre>  <br />

<p>- Aleix</p>

<br />
<p>On February 12th, 2013, 3:10 p.m. UTC, Aurélien Gâteau wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Aaron J. Seigo.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Feb. 12, 2013, 3:10 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix off-by-one error in RunnerModel

The last argument of beginInsertRows() is the row number of the last
inserted row, not the one for the row after.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/declarativeimports/core/runnermodel.cpp <span style="color: \
grey">(ee1b54d45e02f1db8650219e08f6950d0e732a85)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108922/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 