[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108935: Add a DBus method to plasma-desktop to provide support information for ea
From: "Commit Hook" <null () kde ! org>
Date: 2013-02-15 1:25:30
Message-ID: 20130215012530.14652.64796 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108935/#review27497
-----------------------------------------------------------
This review has been submitted with commit f810597f7aa4d6fb9db1db39886825fbe16cf3db \
by David Edmundson to branch KDE/4.10.
- Commit Hook
On Feb. 13, 2013, 12:46 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108935/
> -----------------------------------------------------------
>
> (Updated Feb. 13, 2013, 12:46 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Add a DBus method to plasma-desktop to provide support information for easier bug \
> triaging
> Method call is org.kde.plasma-desktop /App local.PlasmaApp.supportInformation
>
> This is based on kwin support information, and is based a comment made in the \
> quality ML thread. It can probably be extended in many ways but this is an initial \
> version that we can add to as we see fit. Ideally in Plasma2 we can add a support \
> information to the Plasma::Package API if it proves to be worthwhile to get more \
> specific information.
> In it's current state by listing plasmoids we can triage most the python crashes by \
> working out which plasmoid is fault.
> I would like to push this into 4.10.1
>
>
> Diffs
> -----
>
> plasma/desktop/shell/supportinformation.cpp PRE-CREATION
> plasma/desktop/shell/supportinformation.h PRE-CREATION
> plasma/desktop/shell/plasmaapp.cpp aafd037
> plasma/desktop/shell/plasmaapp.h 6ae0c89
> plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32
> plasma/desktop/shell/CMakeLists.txt 95d7db1
>
> Diff: http://git.reviewboard.kde.org/r/108935/diff/
>
>
> Testing
> -------
>
> Sample output attached.
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/02/13/plasma_support_information.txt
>
>
> Thanks,
>
> David Edmundson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108935/">http://git.reviewboard.kde.org/r/108935/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit f810597f7aa4d6fb9db1db39886825fbe16cf3db by David Edmundson to \
branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On February 13th, 2013, 12:46 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Feb. 13, 2013, 12:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add a DBus method to plasma-desktop to provide support information for \
easier bug triaging
Method call is org.kde.plasma-desktop /App local.PlasmaApp.supportInformation
This is based on kwin support information, and is based a comment made in the quality \
ML thread. It can probably be extended in many ways but this is an initial version \
that we can add to as we see fit. Ideally in Plasma2 we can add a support information \
to the Plasma::Package API if it proves to be worthwhile to get more specific \
information.
In it's current state by listing plasmoids we can triage most the python crashes \
by working out which plasmoid is fault.
I would like to push this into 4.10.1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Sample output attached.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/shell/supportinformation.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/shell/supportinformation.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plasma/desktop/shell/plasmaapp.cpp <span style="color: \
grey">(aafd037)</span></li>
<li>plasma/desktop/shell/plasmaapp.h <span style="color: grey">(6ae0c89)</span></li>
<li>plasma/desktop/shell/dbus/org.kde.plasma.App.xml <span style="color: \
grey">(eefce32)</span></li>
<li>plasma/desktop/shell/CMakeLists.txt <span style="color: \
grey">(95d7db1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108935/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/02/13/plasma_support_information.txt">plasma_support_information.txt</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic