'Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108664: Remove absolute paths from Plasma/Generic packages
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-30 8:48:00
Message-ID: 20130130084800.8047.68904 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108664/#review26395
-----------------------------------------------------------

This review has been submitted with commit d291d3affde58b54fa43fe7de64dd7f03a11d191 \
by Aaron Seigo to branch KDE/4.10.

- Commit Hook

On Jan. 30, 2013, 8:43 a.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108664/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 8:43 a.m.)
> 
> 
> Review request for Plasma, Marco Martin and Sebastian Kügler.
> 
> 
> Description
> -------
> 
> This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to \
> compensate for this change, it also introduces the ability for Package to handle \
> relative paths properly, a bit more like what libplasma2 already does. 
> Without this, any Plasma/Generic packages installed in $HOME will render any system \
> installed packages unreachable. 
> 
> This addresses bug 314071.
> http://bugs.kde.org/show_bug.cgi?id=314071
> 
> 
> Diffs
> -----
> 
> plasma/applet.cpp 2f7fbdb 
> plasma/package.cpp 1a49531 
> plasma/packagestructure.cpp b66069c 
> plasma/private/package_p.h a572c12 
> 
> Diff: http://git.reviewboard.kde.org/r/108664/diff/
> 
> 
> Testing
> -------
> 
> packagestructuretest passes; plasmoidviewer still works (installed packages; \
> relative paths; absolute paths); plasma-desktop functions correctly (activity \
> manager and widgets explorer inc); more testing needed. 
> may require a full scan of all uses of Plasma/Generic packages :/
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108664/">http://git.reviewboard.kde.org/r/108664/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit d291d3affde58b54fa43fe7de64dd7f03a11d191 by Aaron Seigo to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 30th, 2013, 8:43 a.m. UTC, Aaron J. Seigo wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Marco Martin and Sebastian Kügler.</div>
<div>By Aaron J. Seigo.</div>

<p style="color: grey;"><i>Updated Jan. 30, 2013, 8:43 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This path gets rid of the absolute defaultRootPath for Plasma/Generic \
packages. to compensate for this change, it also introduces the ability for Package \
to handle relative paths properly, a bit more like what libplasma2 already does.

Without this, any Plasma/Generic packages installed in $HOME will render any system \
installed packages unreachable.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">packagestructuretest passes; plasmoidviewer still works (installed \
packages; relative paths; absolute paths); plasma-desktop functions correctly \
(activity manager and widgets explorer inc); more testing needed.

may require a full scan of all uses of Plasma/Generic packages :/</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=314071">314071</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/applet.cpp <span style="color: grey">(2f7fbdb)</span></li>

 <li>plasma/package.cpp <span style="color: grey">(1a49531)</span></li>

 <li>plasma/packagestructure.cpp <span style="color: grey">(b66069c)</span></li>

 <li>plasma/private/package_p.h <span style="color: grey">(a572c12)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108664/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 