This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108664/ 

This review has been submitted with commit d291d3affde58b54fa43fe7de64dd7f03a11d191 by Aaron Seigo to branch KDE/4.10.

- Commit


On January 30th, 2013, 8:43 a.m. UTC, Aaron J. Seigo wrote:

Review request for Plasma, Marco Martin and Sebastian Kügler.
By Aaron J. Seigo.

Updated Jan. 30, 2013, 8:43 a.m.

Description 

This path gets rid of the absolute defaultRootPath for Plasma/Generic packages. to compensate for this change, it also introduces the ability for Package to handle relative paths properly, a bit more like what libplasma2 already does.

Without this, any Plasma/Generic packages installed in $HOME will render any system installed packages unreachable.

Testing 

packagestructuretest passes; plasmoidviewer still works (installed packages; relative paths; absolute paths); plasma-desktop functions correctly (activity manager and widgets explorer inc); more testing needed.

may require a full scan of all uses of Plasma/Generic packages :/
Bugs: 314071

Diffs

  • plasma/applet.cpp (2f7fbdb)
  • plasma/package.cpp (1a49531)
  • plasma/packagestructure.cpp (b66069c)
  • plasma/private/package_p.h (a572c12)

View Diff