[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108640: Check for Valid Wallet Pointer
From: "Commit Hook" <null () kde ! org>
Date: 2013-01-28 13:31:57
Message-ID: 20130128133157.6191.62486 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108640/#review26308
-----------------------------------------------------------
This review has been submitted with commit 6e626a7c6ace1b1101d7db512c8c129d3bb32811 \
by David E. Narváez to branch KDE/4.10.
- Commit Hook
On Jan. 28, 2013, 12:40 p.m., David Narváez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108640/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2013, 12:40 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Related to bug 312137. According to the documentation, the wallet pointer can be \
> null if it was denied, so we need to check for null values before the other checks. \
>
> Diffs
> -----
>
> dataengines/microblog/koauth.cpp 7566b95
>
> Diff: http://git.reviewboard.kde.org/r/108640/diff/
>
>
> Testing
> -------
>
> 1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
> 2. Add a microblogging plasmoid
> 3. Configure your plasmoid with an identi.ca account
> 4. Deny any kwallet prompt
>
> Before this path it would crash trying to store the access tokens.
>
>
> Thanks,
>
> David Narváez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108640/">http://git.reviewboard.kde.org/r/108640/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 6e626a7c6ace1b1101d7db512c8c129d3bb32811 by David E. Narváez \
to branch KDE/4.10.</pre> <br />
<p>- Commit</p>
<br />
<p>On January 28th, 2013, 12:40 p.m. UTC, David Narváez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By David Narváez.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2013, 12:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Related to bug 312137. According to the documentation, the wallet \
pointer can be null if it was denied, so we need to check for null values before the \
other checks.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">1. Make sure your plasma desktop does not have "Allow Always" \
in your kwallet 2. Add a microblogging plasmoid
3. Configure your plasmoid with an identi.ca account
4. Deny any kwallet prompt
Before this path it would crash trying to store the access tokens.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/microblog/koauth.cpp <span style="color: grey">(7566b95)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108640/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic