From kde-panel-devel Mon Jan 28 13:31:57 2013 From: "Commit Hook" Date: Mon, 28 Jan 2013 13:31:57 +0000 To: kde-panel-devel Subject: Re: Review Request 108640: Check for Valid Wallet Pointer Message-Id: <20130128133157.6191.62486 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135937994232658 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4650114321317584555==" --===============4650114321317584555== Content-Type: multipart/alternative; boundary="===============8062455726545019007==" --===============8062455726545019007== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/#review26308 ----------------------------------------------------------- This review has been submitted with commit 6e626a7c6ace1b1101d7db512c8c129d3bb32811 by David E. Narváez to branch KDE/4.10. - Commit Hook On Jan. 28, 2013, 12:40 p.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108640/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2013, 12:40 p.m.) > > > Review request for Plasma. > > > Description > ------- > > Related to bug 312137. According to the documentation, the wallet pointer can be null if it was denied, so we need to check for null values before the other checks. > > > Diffs > ----- > > dataengines/microblog/koauth.cpp 7566b95 > > Diff: http://git.reviewboard.kde.org/r/108640/diff/ > > > Testing > ------- > > 1. Make sure your plasma desktop does not have "Allow Always" in your kwallet > 2. Add a microblogging plasmoid > 3. Configure your plasmoid with an identi.ca account > 4. Deny any kwallet prompt > > Before this path it would crash trying to store the access tokens. > > > Thanks, > > David Narváez > > --===============8062455726545019007== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108640/

This review has been submitted with commit 6e626a7c6ace1b1101d7db512c8c129d3bb32811 by David E. Narváez to branch KDE/4.10.

- Commit

On January 28th, 2013, 12:40 p.m. UTC, David Narváez wrote:

Review request for Plasma.

By David Narváez.

Updated Jan. 28, 2013, 12:40 p.m.

Description

Related to bug 312137. According to the documentation, the wallet pointer can be null if it was denied, so we need to check for null values before the other checks.

Testing

1. Make sure your plasma desktop does not have "Allow Always" in your kwallet
2. Add a microblogging plasmoid
3. Configure your plasmoid with an identi.ca account
4. Deny any kwallet prompt

Before this path it would crash trying to store the access tokens.

Diffs

dataengines/microblog/koauth.cpp (7566b95)

View Diff

--===============8062455726545019007==-- --===============4650114321317584555== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4650114321317584555==--