'Re: Review Request 108465: a couple of fixes in participant/changeAccountDetails'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108465: a couple of fixes in participant/changeAccountDetails
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-24 13:17:41
Message-ID: 20130124131741.13746.73588 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108465/#review26128
-----------------------------------------------------------

This review has been submitted with commit 34c8d0aa7d9cd703981d638c4240ffdbae5e81b5 \
by Giorgos Tsiapaliokas to branch master.

- Commit Hook

On Jan. 18, 2013, 7:38 a.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108465/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 7:38 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This does does 2 things:
> 
> 1. adds a next() in order sometime to reach completeUpdate(), right now it doesn't
> 2. removes next() from completeUpdate(), completeUpdate is tha last method we don't \
> have others, so we don't need this next()
> 
> 
> Diffs
> -----
> 
> server/lib/db/changeAccountDetails.js fb5711b 
> 
> Diff: http://git.reviewboard.kde.org/r/108465/diff/
> 
> 
> Testing
> -------
> 
> i haven't noticed something wrong
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108465/">http://git.reviewboard.kde.org/r/108465/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 34c8d0aa7d9cd703981d638c4240ffdbae5e81b5 by Giorgos \
Tsiapaliokas to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 18th, 2013, 7:38 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Jan. 18, 2013, 7:38 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This does does 2 things:

1. adds a next() in order sometime to reach completeUpdate(), right now it \
doesn&#39;t 2. removes next() from completeUpdate(), completeUpdate is tha last \
method we don&#39;t have others, so we don&#39;t need this next()</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i haven&#39;t noticed something wrong</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>server/lib/db/changeAccountDetails.js <span style="color: \
grey">(fb5711b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108465/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 