[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 108465: a couple of fixes in participant/changeAccountDetails
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2013-01-21 12:20:13
Message-ID: 20130121122013.8385.66409 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108465/#review25888
-----------------------------------------------------------
Ship it!
other than the one next() that should remain, this looks fine. put that next() back \
in and then push it.
server/lib/db/changeAccountDetails.js
<http://git.reviewboard.kde.org/r/108465/#comment19795>
should remain just so that if something does get added to it later, we don't have \
to track down where it isn't getting next() from
- Aaron J. Seigo
On Jan. 18, 2013, 7:38 a.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108465/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 7:38 a.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> This does does 2 things:
>
> 1. adds a next() in order sometime to reach completeUpdate(), right now it doesn't
> 2. removes next() from completeUpdate(), completeUpdate is tha last method we don't \
> have others, so we don't need this next()
>
>
> Diffs
> -----
>
> server/lib/db/changeAccountDetails.js fb5711b
>
> Diff: http://git.reviewboard.kde.org/r/108465/diff/
>
>
> Testing
> -------
>
> i haven't noticed something wrong
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108465/">http://git.reviewboard.kde.org/r/108465/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">other than the one \
next() that should remain, this looks fine. put that next() back in and then push \
it.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/108465/diff/1/?file=107703#file107703line165" \
style="color: black; font-weight: bold; text-decoration: \
underline;">server/lib/db/changeAccountDetails.js</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">function performCardUpdate(db, req, res, next)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">163</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="nx">next</span><span class="p">();</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">should \
remain just so that if something does get added to it later, we don't have to \
track down where it isn't getting next() from</pre> </div>
<br />
<p>- Aaron J.</p>
<br />
<p>On January 18th, 2013, 7:38 a.m. UTC, Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2013, 7:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This does does 2 things:
1. adds a next() in order sometime to reach completeUpdate(), right now it \
doesn't 2. removes next() from completeUpdate(), completeUpdate is tha last \
method we don't have others, so we don't need this next()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">i haven't noticed something wrong</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>server/lib/db/changeAccountDetails.js <span style="color: \
grey">(fb5711b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108465/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic