'Re: Review Request 108441: prevent false positive mouse deactivation of screensaver'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 108441: prevent false positive mouse deactivation of screensaver
From:       "Commit Hook" <null () kde ! org>
Date:       2013-01-23 21:12:27
Message-ID: 20130123211227.8933.69904 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108441/#review26095
-----------------------------------------------------------

This review has been submitted with commit 2d234a76e269a2a42d78ca5744021f12f6120d99 \
by Thomas Lübking to branch master.

- Commit Hook

On Jan. 16, 2013, 4:08 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108441/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2013, 4:08 p.m.)
> 
> 
> Review request for Plasma, Marco Martin and Oliver Henshaw.
> 
> 
> Description
> -------
> 
> The mouse movement is not correctly accounted.
> Showing the window will cause an immediate moveEvent being "too big", so the \
> measure point is set to a second invalid position to hint that this comes from a \
> show. 
> As a minor change the pointless check right after setting the cursor pos to the \
> current is omitted. 
> 
> This addresses bugs (CC) and 311116.
> http://bugs.kde.org/show_bug.cgi?id=(CC)
> http://bugs.kde.org/show_bug.cgi?id=311116
> 
> 
> Diffs
> -----
> 
> ksmserver/screenlocker/greeter/screensaverwindow.cpp 10ae31e 
> 
> Diff: http://git.reviewboard.kde.org/r/108441/diff/
> 
> 
> Testing
> -------
> 
> Yes, also no dangerous asserts included (turned out i've debug compiling only fake \
> enabled for kwin ;-) 
> 
> Thanks,
> 
> Thomas Lübking
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108441/">http://git.reviewboard.kde.org/r/108441/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 2d234a76e269a2a42d78ca5744021f12f6120d99 by Thomas Lübking to \
branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On January 16th, 2013, 4:08 p.m. UTC, Thomas Lübking wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Marco Martin and Oliver Henshaw.</div>
<div>By Thomas Lübking.</div>

<p style="color: grey;"><i>Updated Jan. 16, 2013, 4:08 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The mouse movement is not correctly accounted. Showing the window will \
cause an immediate moveEvent being &quot;too big&quot;, so the measure point is set \
to a second invalid position to hint that this comes from a show.

As a minor change the pointless check right after setting the cursor pos to the \
current is omitted.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, also no dangerous asserts included (turned out i&#39;ve debug \
compiling only fake enabled for kwin ;-)</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=(CC)">(CC)</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=311116">311116</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ksmserver/screenlocker/greeter/screensaverwindow.cpp <span style="color: \
grey">(10ae31e)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108441/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 