--===============0033528782292595952== Content-Type: multipart/alternative; boundary="===============4914426556065122195==" --===============4914426556065122195== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108441/#review26095 ----------------------------------------------------------- This review has been submitted with commit 2d234a76e269a2a42d78ca5744021f12f6120d99 by Thomas Lübking to branch master. - Commit Hook On Jan. 16, 2013, 4:08 p.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108441/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 4:08 p.m.) > > > Review request for Plasma, Marco Martin and Oliver Henshaw. > > > Description > ------- > > The mouse movement is not correctly accounted. > Showing the window will cause an immediate moveEvent being "too big", so the measure point is set to a second invalid position to hint that this comes from a show. > > As a minor change the pointless check right after setting the cursor pos to the current is omitted. > > > This addresses bugs (CC) and 311116. > http://bugs.kde.org/show_bug.cgi?id=(CC) > http://bugs.kde.org/show_bug.cgi?id=311116 > > > Diffs > ----- > > ksmserver/screenlocker/greeter/screensaverwindow.cpp 10ae31e > > Diff: http://git.reviewboard.kde.org/r/108441/diff/ > > > Testing > ------- > > Yes, also no dangerous asserts included (turned out i've debug compiling only fake enabled for kwin ;-) > > > Thanks, > > Thomas Lübking > > --===============4914426556065122195== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108441/

This review has been submitted with commit 2d234a76e269a2a42d78ca5744021f12f6120d99 by Thomas Lübking to branch master.

- Commit

On January 16th, 2013, 4:08 p.m. UTC, Thomas Lübking wrote:

Review request for Plasma, Marco Martin and Oliver Henshaw.

By Thomas Lübking.

Updated Jan. 16, 2013, 4:08 p.m.

Description

The mouse movement is not correctly accounted.
Showing the window will cause an immediate moveEvent being "too big", so the measure point is set to a second invalid position to hint that this comes from a show.

As a minor change the pointless check right after setting the cursor pos to the current is omitted.

Testing

Yes, also no dangerous asserts included (turned out i've debug compiling only fake enabled for kwin ;-)

Bugs: (CC), 311116

Diffs

ksmserver/screenlocker/greeter/screensaverwindow.cpp (10ae31e)

View Diff

--===============4914426556065122195==-- --===============0033528782292595952== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============0033528782292595952==--