[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: try fix tooltip shadow problem
From: Thomas_Lübking <thomas.luebking () web ! de>
Date: 2012-12-25 21:44:27
Message-ID: 20121225214427.1510.57275 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107905/#review23982
-----------------------------------------------------------
Seems to be an insufficient repaint area - pot. related to bug #312168.
Wild guess from your patch: don't remove the shadows before, but *after* the hiding \
(eventually "later", ie. in the deconstructor or on the destroyed signal) to avoid \
confusations between the deleted window size and the "dirty" area.
- Thomas Lübking
On Dec. 25, 2012, 12:14 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107905/
> -----------------------------------------------------------
>
> (Updated Dec. 25, 2012, 12:14 a.m.)
>
>
> Review request for kdelibs, Plasma and Aaron J. Seigo.
>
>
> Description
> -------
>
> Well. I'm not an expert in kwin related stuff, this patch is basically revert \
> 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don't know the real reason for \
> that.
> And actually, remove by handle is not necessary, since dialogshadows already \
> connect to the widget's destroyed signal, hence it will handle that gracefully.
>
> This addresses bug 311502.
> http://bugs.kde.org/show_bug.cgi?id=311502
>
>
> Diffs
> -----
>
> plasma/tooltipmanager.cpp 00bfcdb
>
> Diff: http://git.reviewboard.kde.org/r/107905/diff/
>
>
> Testing
> -------
>
> seems it fixed, but not sure it's the right way.
>
>
> Thanks,
>
> Xuetian Weng
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107905/">http://git.reviewboard.kde.org/r/107905/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seems to be an \
insufficient repaint area - pot. related to bug #312168.
Wild guess from your patch: don't remove the shadows before, but *after* the \
hiding (eventually "later", ie. in the deconstructor or on the destroyed \
signal) to avoid confusations between the deleted window size and the \
"dirty" area.</pre> <br />
<p>- Thomas</p>
<br />
<p>On December 25th, 2012, 12:14 a.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for kdelibs, Plasma and Aaron J. Seigo.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Dec. 25, 2012, 12:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Well. I'm not an expert in kwin related stuff, this patch is \
basically revert 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don't know the \
real reason for that.
And actually, remove by handle is not necessary, since dialogshadows already connect \
to the widget's destroyed signal, hence it will handle that gracefully.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">seems it fixed, but not sure it's the right way.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=311502">311502</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/tooltipmanager.cpp <span style="color: grey">(00bfcdb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107905/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic