From kde-core-devel Tue Dec 25 21:44:27 2012 From: =?utf-8?q?Thomas_L=C3=BCbking?= Date: Tue, 25 Dec 2012 21:44:27 +0000 To: kde-core-devel Subject: Re: Review Request: try fix tooltip shadow problem Message-Id: <20121225214427.1510.57275 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-core-devel&m=135647189718245 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0694469219928311263==" --===============0694469219928311263== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107905/#review23982 ----------------------------------------------------------- Seems to be an insufficient repaint area - pot. related to bug #312168. Wild guess from your patch: don't remove the shadows before, but *after* th= e hiding (eventually "later", ie. in the deconstructor or on the destroyed = signal) to avoid confusations between the deleted window size and the "dirt= y" area. - Thomas L=C3=BCbking On Dec. 25, 2012, 12:14 a.m., Xuetian Weng wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107905/ > ----------------------------------------------------------- > = > (Updated Dec. 25, 2012, 12:14 a.m.) > = > = > Review request for kdelibs, Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > Well. I'm not an expert in kwin related stuff, this patch is basically re= vert 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don't know the real re= ason for that. > = > And actually, remove by handle is not necessary, since dialogshadows alre= ady connect to the widget's destroyed signal, hence it will handle that gra= cefully. > = > = > This addresses bug 311502. > http://bugs.kde.org/show_bug.cgi?id=3D311502 > = > = > Diffs > ----- > = > plasma/tooltipmanager.cpp 00bfcdb = > = > Diff: http://git.reviewboard.kde.org/r/107905/diff/ > = > = > Testing > ------- > = > seems it fixed, but not sure it's the right way. > = > = > Thanks, > = > Xuetian Weng > = > --===============0694469219928311263== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107905/

Seems to b=
e an insufficient repaint area - pot. related to bug #312168.

Wild guess from your patch: don't remove the shadows before, but *after=
* the hiding (eventually "later", ie. in the deconstructor or on =
the destroyed signal) to avoid confusations between the deleted window size=
 and the "dirty" area.

- Thomas

On December 25th, 2012, 12:14 a.m., Xuetian Weng wrote:

Review request for kdelibs, Plasma and Aaron J. Seigo.

By Xuetian Weng.

Updated Dec. 25, 2012, 12:14 a.m.

Descripti= on

Well. I'm not an expert in kwin related stuff, this patc=
h is basically revert 157a06e46f46ba83ba37a93b400647f4886e18c9, but I don&#=
39;t know the real reason for that.

And actually, remove by handle is not necessary, since dialogshadows alread=
y connect to the widget's destroyed signal, hence it will handle that g=
racefully.

Testing <= /h1>

seems it fixed, but not sure it's the right way.

Bugs: 311502

Diffs=

plasma/tooltipmanager.cpp (00bfcdb)=

--===============0694469219928311263==--