'Re: Review Request: Fix pager window dragging and icon'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix pager window dragging and icon
From:       "Commit Hook" <null () kde ! org>
Date:       2012-12-23 2:01:21
Message-ID: 20121223020121.22811.88509 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107828/#review23875
-----------------------------------------------------------

This review has been submitted with commit 64a17885b22a13ae73e2a89d0e29216a5cf2b481 \
by Weng Xuetian to branch KDE/4.10.

- Commit Hook

On Dec. 21, 2012, 4:35 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107828/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2012, 4:35 a.m.)
> 
> 
> Review request for kde-workspace, Plasma and Aaron J. Seigo.
> 
> 
> Description
> -------
> 
> Current region is obviously wrong, and I have idea why it's in current state.
> I'm now using the same strategy with X axis range, so far no problem.
> 
> And limit the icon visibility if the window is too small.
> 
> 
> This addresses bug 310475.
> http://bugs.kde.org/show_bug.cgi?id=310475
> 
> 
> Diffs
> -----
> 
> plasma/desktop/applets/pager/package/contents/ui/main.qml 40a829d 
> 
> Diff: http://git.reviewboard.kde.org/r/107828/diff/
> 
> 
> Testing
> -------
> 
> No problem.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107828/">http://git.reviewboard.kde.org/r/107828/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 64a17885b22a13ae73e2a89d0e29216a5cf2b481 by Weng Xuetian to \
branch KDE/4.10.</pre>  <br />

<p>- Commit</p>

<br />
<p>On December 21st, 2012, 4:35 a.m., Xuetian Weng wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace, Plasma and Aaron J. Seigo.</div>
<div>By Xuetian Weng.</div>

<p style="color: grey;"><i>Updated Dec. 21, 2012, 4:35 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Current region is obviously wrong, and I have idea why it&#39;s in \
current state. I&#39;m now using the same strategy with X axis range, so far no \
problem.

And limit the icon visibility if the window is too small.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No problem.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=310475">310475</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/pager/package/contents/ui/main.qml <span style="color: \
grey">(40a829d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107828/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 