From kde-panel-devel Sun Dec 23 02:01:21 2012 From: "Commit Hook" Date: Sun, 23 Dec 2012 02:01:21 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix pager window dragging and icon Message-Id: <20121223020121.22811.88509 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135622814820922 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4162083791496211262==" --===============4162083791496211262== Content-Type: multipart/alternative; boundary="===============4886216544865573410==" --===============4886216544865573410== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107828/#review23875 ----------------------------------------------------------- This review has been submitted with commit 64a17885b22a13ae73e2a89d0e29216a= 5cf2b481 by Weng Xuetian to branch KDE/4.10. - Commit Hook On Dec. 21, 2012, 4:35 a.m., Xuetian Weng wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107828/ > ----------------------------------------------------------- > = > (Updated Dec. 21, 2012, 4:35 a.m.) > = > = > Review request for kde-workspace, Plasma and Aaron J. Seigo. > = > = > Description > ------- > = > Current region is obviously wrong, and I have idea why it's in current st= ate. > I'm now using the same strategy with X axis range, so far no problem. > = > And limit the icon visibility if the window is too small. > = > = > This addresses bug 310475. > http://bugs.kde.org/show_bug.cgi?id=3D310475 > = > = > Diffs > ----- > = > plasma/desktop/applets/pager/package/contents/ui/main.qml 40a829d = > = > Diff: http://git.reviewboard.kde.org/r/107828/diff/ > = > = > Testing > ------- > = > No problem. > = > = > Thanks, > = > Xuetian Weng > = > --===============4886216544865573410== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107828/ 

This revie=
w has been submitted with commit 64a17885b22a13ae73e2a89d0e29216a5cf2b481 b=
y Weng Xuetian to branch KDE/4.10.

- Commit


On December 21st, 2012, 4:35 a.m., Xuetian Weng wrote:

Review request for kde-workspace, Plasma and Aaron J. Seigo.
By Xuetian Weng.

Updated Dec. 21, 2012, 4:35 a.m.

Descripti= on 

Current region is obviously wrong, and I have idea why it=
9;s in current state.
I'm now using the same strategy with X axis range, so far no problem.

And limit the icon visibility if the window is too small.

Testing <= /h1> 
No problem.
Bugs: 310475

Diffs=

  • plasma/desktop/applets/pager/package/contents/ui/main.qml (40a829d)

View Diff
--===============4886216544865573410==-- --===============4162083791496211262== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4162083791496211262==--