[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Plasmate:Remove cmake-install functionality from Publisher
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-29 14:42:02
Message-ID: 20121129144202.4450.33117 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107512/#review22761
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Nov. 29, 2012, 1:56 p.m., Antonis Tsiapaliokas wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107512/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2012, 1:56 p.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> In this patch the cmake-install functionality is being removed.
> When plasmate, is installed under the "/usr", the cmake-install functiona=
lity is causing some issues.
> So for the 1.0 release, we are removing the cmake-install functionality.
> =
> =
> Diffs
> -----
> =
> plasmate/publisher/publisher.h de5d884 =
> plasmate/publisher/publisher.cpp 61930fc =
> plasmate/templates/CMakeLists.txt 64ae27c =
> plasmate/templates/cmakelists 5cb4dae =
> plasmate/templates/cmakelistsKWinEffect cd91838 =
> plasmate/templates/cmakelistsKWinScript 992d4c6 =
> plasmate/templates/cmakelistsWindowSwitcher 761d043 =
> =
> Diff: http://git.reviewboard.kde.org/r/107512/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Antonis Tsiapaliokas
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107512/">http://git.reviewboard.kde.org/r/107512/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 29th, 2012, 1:56 p.m., Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2012, 1:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In this patch the cmake-install functionality is being removed. When \
plasmate, is installed under the "/usr", the cmake-install functionality is \
causing some issues. So for the 1.0 release, we are removing the cmake-install \
functionality.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/publisher/publisher.h <span style="color: grey">(de5d884)</span></li>
<li>plasmate/publisher/publisher.cpp <span style="color: grey">(61930fc)</span></li>
<li>plasmate/templates/CMakeLists.txt <span style="color: \
grey">(64ae27c)</span></li>
<li>plasmate/templates/cmakelists <span style="color: grey">(5cb4dae)</span></li>
<li>plasmate/templates/cmakelistsKWinEffect <span style="color: \
grey">(cd91838)</span></li>
<li>plasmate/templates/cmakelistsKWinScript <span style="color: \
grey">(992d4c6)</span></li>
<li>plasmate/templates/cmakelistsWindowSwitcher <span style="color: \
grey">(761d043)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107512/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic