'Re: Review Request: populate the settings of the rssnow-qml plasmoid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: populate the settings of the rssnow-qml plasmoid
From:       "Commit Hook" <null () kde ! org>
Date:       2012-11-29 14:33:24
Message-ID: 20121129143324.3983.98260 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106582/#review22760
-----------------------------------------------------------

This review has been submitted with commit 3eff802699ab328af27c5269d4284e29=
97d9bab4 by Giorgos Tsiapaliokas to branch master.

- Commit Hook

On Nov. 26, 2012, 2:45 p.m., Giorgos Tsiapaliokas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106582/
> -----------------------------------------------------------
> =

> (Updated Nov. 26, 2012, 2:45 p.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> I have populated the settings of the rssnow-qml plasmoid
> and they are identical to the ones of the c++ one.
> =

> In order to do that I made the rssnow-qml plasmoid into a hybrid.
> =

> After submit of this review I believe that it is ready to be
> moved into the kdeplasma-addons and to remove the c++ one.
> (I would prefer to open a new review for the move)
> =

> Also I have pushed the latest changes(this diff) into the
> terietor/rssnow/settings branch in declarative-plasmoids
> =

> =

> Diffs
> -----
> =

>   rssnow/CMakeLists.txt 79b3581 =

>   rssnow/feedsConfig.ui PRE-CREATION =

>   rssnow/generalConfig.ui PRE-CREATION =

>   rssnow/package/contents/config/main.xml e05fcbf =

>   rssnow/package/contents/ui/DropRssEntry.qml PRE-CREATION =

>   rssnow/package/contents/ui/ListItemEntry.qml 657b14b =

>   rssnow/package/contents/ui/config.ui e1e3409 =

>   rssnow/package/contents/ui/main.qml a575c29 =

>   rssnow/package/metadata.desktop ef72f15 =

>   rssnow/plasma-applet-rssnow-qml.desktop ef72f15 =

>   rssnow/plasma-applet-rssnow.desktop PRE-CREATION =

>   rssnow/rssnow.h PRE-CREATION =

>   rssnow/rssnow.cpp PRE-CREATION =

> =

> Diff: http://git.reviewboard.kde.org/r/106582/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Giorgos Tsiapaliokas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106582/">http://git.reviewboard.kde.org/r/106582/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 3eff802699ab328af27c5269d4284e2997d9bab4 by Giorgos \
Tsiapaliokas to branch master.</pre>  <br />

<p>- Commit</p>

<br />
<p>On November 26th, 2012, 2:45 p.m., Giorgos Tsiapaliokas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2012, 2:45 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have populated the settings of the rssnow-qml plasmoid and they are \
identical to the ones of the c++ one.

In order to do that I made the rssnow-qml plasmoid into a hybrid.

After submit of this review I believe that it is ready to be
moved into the kdeplasma-addons and to remove the c++ one.
(I would prefer to open a new review for the move)

Also I have pushed the latest changes(this diff) into the
terietor/rssnow/settings branch in declarative-plasmoids</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>rssnow/CMakeLists.txt <span style="color: grey">(79b3581)</span></li>

 <li>rssnow/feedsConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>rssnow/generalConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>

 <li>rssnow/package/contents/config/main.xml <span style="color: \
grey">(e05fcbf)</span></li>

 <li>rssnow/package/contents/ui/DropRssEntry.qml <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>rssnow/package/contents/ui/ListItemEntry.qml <span style="color: \
grey">(657b14b)</span></li>

 <li>rssnow/package/contents/ui/config.ui <span style="color: \
grey">(e1e3409)</span></li>

 <li>rssnow/package/contents/ui/main.qml <span style="color: \
grey">(a575c29)</span></li>

 <li>rssnow/package/metadata.desktop <span style="color: grey">(ef72f15)</span></li>

 <li>rssnow/plasma-applet-rssnow-qml.desktop <span style="color: \
grey">(ef72f15)</span></li>

 <li>rssnow/plasma-applet-rssnow.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>rssnow/rssnow.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>rssnow/rssnow.cpp <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106582/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 