[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Set history size before reading history so that all history can be loaded
From: "Commit Hook" <null () kde ! org>
Date: 2012-11-29 13:54:41
Message-ID: 20121129135441.30568.52059 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107499/#review22756
-----------------------------------------------------------
This review has been submitted with commit 723a484bf738459c609b48edb038630c=
5a923cc1 by Yichao Yu to branch master.
- Commit Hook
On Nov. 28, 2012, 1:34 a.m., Yichao Yu wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107499/
> -----------------------------------------------------------
> =
> (Updated Nov. 28, 2012, 1:34 a.m.)
> =
> =
> Review request for Plasma.
> =
> =
> Description
> -------
> =
> The pastebin applet always only read at most 3 histories from file on sta=
rtup since the history size is still the default value 3 when these histori=
es are added. This patch set the maximum size before histories are added.
> =
> =
> Diffs
> -----
> =
> applets/pastebin/pastebin.cpp 208e6a3 =
> =
> Diff: http://git.reviewboard.kde.org/r/107499/diff/
> =
> =
> Testing
> -------
> =
> Compiled and installed.
> Set history size to > 3 and upload > 3 images/text files.
> Restart plasma and the history list is of the correct size.
> =
> =
> Thanks,
> =
> Yichao Yu
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107499/">http://git.reviewboard.kde.org/r/107499/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 723a484bf738459c609b48edb038630c5a923cc1 by Yichao Yu to branch \
master.</pre> <br />
<p>- Commit</p>
<br />
<p>On November 28th, 2012, 1:34 a.m., Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2012, 1:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The pastebin applet always only read at most 3 histories from file on \
startup since the history size is still the default value 3 when these histories are \
added. This patch set the maximum size before histories are added. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiled and installed. Set history size to > 3 and upload > 3 \
images/text files. Restart plasma and the history list is of the correct size.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/pastebin/pastebin.cpp <span style="color: grey">(208e6a3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107499/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic