From kde-panel-devel Thu Nov 29 13:54:41 2012 From: "Commit Hook" Date: Thu, 29 Nov 2012 13:54:41 +0000 To: kde-panel-devel Subject: Re: Review Request: Set history size before reading history so that all history can be loaded Message-Id: <20121129135441.30568.52059 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135419729805798 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5973860831774658475==" --===============5973860831774658475== Content-Type: multipart/alternative; boundary="===============3167224743529269077==" --===============3167224743529269077== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107499/#review22756 ----------------------------------------------------------- This review has been submitted with commit 723a484bf738459c609b48edb038630c= 5a923cc1 by Yichao Yu to branch master. - Commit Hook On Nov. 28, 2012, 1:34 a.m., Yichao Yu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107499/ > ----------------------------------------------------------- > = > (Updated Nov. 28, 2012, 1:34 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > The pastebin applet always only read at most 3 histories from file on sta= rtup since the history size is still the default value 3 when these histori= es are added. This patch set the maximum size before histories are added. > = > = > Diffs > ----- > = > applets/pastebin/pastebin.cpp 208e6a3 = > = > Diff: http://git.reviewboard.kde.org/r/107499/diff/ > = > = > Testing > ------- > = > Compiled and installed. > Set history size to > 3 and upload > 3 images/text files. > Restart plasma and the history list is of the correct size. > = > = > Thanks, > = > Yichao Yu > = > --===============3167224743529269077== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107499/ 

This revie=
w has been submitted with commit 723a484bf738459c609b48edb038630c5a923cc1 b=
y Yichao Yu to branch master.

- Commit


On November 28th, 2012, 1:34 a.m., Yichao Yu wrote:

Review request for Plasma.
By Yichao Yu.

Updated Nov. 28, 2012, 1:34 a.m.

Descripti= on 

The pastebin applet always only read at most 3 histories fro=
m file on startup since the history size is still the default value 3 when =
these histories are added. This patch set the maximum size before histories=
 are added.

Testing <= /h1> 
Compiled and installed.
Set history size to > 3 and upload > 3 images/text files.
Restart plasma and the history list is of the correct size.

Diffs=

  • applets/pastebin/pastebin.cpp (208e6a3)

View Diff
--===============3167224743529269077==-- --===============5973860831774658475== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5973860831774658475==--