[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: kconfigxteditor refactor
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-11-29 13:48:28
Message-ID: 20121129134828.27613.95297 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107394/#review22753
-----------------------------------------------------------
Ship it!
Ship It!
- Aaron J. Seigo
On Nov. 20, 2012, 2:33 p.m., Giorgos Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107394/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2012, 2:33 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> What has been done in the refactoring
> 1. replace QXmlStream* with QDom*
> 2. remove the old replace-by-hand code
> 3. simplify the code
> 4. reduce the code
> 7 files changed, 411 insertions(+), 576 deletions(-)
>
> There is only one issue, kconfigxteditor won't reformat correctly the current \
> namespaces of the XMLs
> the above
> <kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
> xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
> http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
>
> will become this,
> <kcfg xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" \
> xmlns="http://www.kde.org/standards/kcfg/1.0" \
> xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
 \
> http://www.kde.org/standards/kcfg/1.0/kcfg.xsd">
> the issue is in the newline, by removing by hand with $EDITOR fixes the issue.
>
>
> Diffs
> -----
>
> plasmate/editors/kconfigxt/kconfigxteditor.h e6cd65e
> plasmate/editors/kconfigxt/kconfigxteditor.cpp 6f585fc
> plasmate/editors/kconfigxt/kconfigxtreader.h 8e923e9
> plasmate/editors/kconfigxt/kconfigxtreader.cpp 21ce6ea
> plasmate/editors/kconfigxt/kconfigxtwriter.h d3560cd
> plasmate/editors/kconfigxt/kconfigxtwriter.cpp 20d6459
> plasmate/mainwindow.cpp 87d6fe3
>
> Diff: http://git.reviewboard.kde.org/r/107394/diff/
>
>
> Testing
> -------
>
> In the attached image I have modified the main.xml of dictionary and it works.
>
>
> Thanks,
>
> Giorgos Tsiapaliokas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107394/">http://git.reviewboard.kde.org/r/107394/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Aaron J.</p>
<br />
<p>On November 20th, 2012, 2:33 p.m., Giorgos Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2012, 2:33 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">What has been done in the refactoring 1. replace QXmlStream* with QDom*
2. remove the old replace-by-hand code
3. simplify the code
4. reduce the code
7 files changed, 411 insertions(+), 576 deletions(-)
There is only one issue, kconfigxteditor won't reformat correctly the current \
namespaces of the XMLs
the above
<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >
will become this,
<kcfg xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" \
xmlns="http://www.kde.org/standards/kcfg/1.0" \
xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0&#xa; \
http://www.kde.org/standards/kcfg/1.0/kcfg.xsd">
the issue is in the newline, by removing by hand with $EDITOR fixes the issue.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">In the attached image I have modified the main.xml of dictionary and it \
works. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasmate/editors/kconfigxt/kconfigxteditor.h <span style="color: \
grey">(e6cd65e)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxteditor.cpp <span style="color: \
grey">(6f585fc)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtreader.h <span style="color: \
grey">(8e923e9)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtreader.cpp <span style="color: \
grey">(21ce6ea)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtwriter.h <span style="color: \
grey">(d3560cd)</span></li>
<li>plasmate/editors/kconfigxt/kconfigxtwriter.cpp <span style="color: \
grey">(20d6459)</span></li>
<li>plasmate/mainwindow.cpp <span style="color: grey">(87d6fe3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107394/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic