This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107394/

Ship it!

Ship It!

- Aaron J.


On November 20th, 2012, 2:33 p.m., Giorgos Tsiapaliokas wrote:

Review request for Plasma.
By Giorgos Tsiapaliokas.

Updated Nov. 20, 2012, 2:33 p.m.

Description

What has been done in the refactoring
1. replace QXmlStream* with QDom*
2. remove the old replace-by-hand code
3. simplify the code
4. reduce the code
7 files changed, 411 insertions(+), 576 deletions(-)

There is only one issue, kconfigxteditor won't reformat correctly the current namespaces of the XMLs

the above
<kcfg xmlns="http://www.kde.org/standards/kcfg/1.0"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0
      http://www.kde.org/standards/kcfg/1.0/kcfg.xsd" >

will become this,
<kcfg xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.kde.org/standards/kcfg/1.0" xsi:schemaLocation="http://www.kde.org/standards/kcfg/1.0&#xa;      http://www.kde.org/standards/kcfg/1.0/kcfg.xsd">

the issue is in the newline, by removing by hand with $EDITOR fixes the issue.

Testing

In the attached image I have modified the main.xml of dictionary and it works.

Diffs

  • plasmate/editors/kconfigxt/kconfigxteditor.h (e6cd65e)
  • plasmate/editors/kconfigxt/kconfigxteditor.cpp (6f585fc)
  • plasmate/editors/kconfigxt/kconfigxtreader.h (8e923e9)
  • plasmate/editors/kconfigxt/kconfigxtreader.cpp (21ce6ea)
  • plasmate/editors/kconfigxt/kconfigxtwriter.h (d3560cd)
  • plasmate/editors/kconfigxt/kconfigxtwriter.cpp (20d6459)
  • plasmate/mainwindow.cpp (87d6fe3)

View Diff