[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: SystemTray: Refactoring: UiTask and TasksPool have been removed
From: "Dmitry Ashkadov" <dmitry.ashkadov () rosalab ! ru>
Date: 2012-10-31 19:00:14
Message-ID: 20121031190014.14575.22858 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107160/
-----------------------------------------------------------
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Description
-------
Aaron has noticed in his mail to plasma-devel that the system tray requires=
some refactoring. This is a first step of refactoring. If it is approved I=
'll continue work on system tray.
Diffs
-----
plasma/generic/applets/systemtray/CMakeLists.txt d3478a8 =
plasma/generic/applets/systemtray/core/manager.h 3b6b6f8 =
plasma/generic/applets/systemtray/core/manager.cpp c23225e =
plasma/generic/applets/systemtray/core/task.h 66bf6e1 =
plasma/generic/applets/systemtray/core/task.cpp 8754785 =
plasma/generic/applets/systemtray/package/contents/code/main.js 10518cd =
plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml f251c=
c5 =
plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.=
qml 27d476a =
plasma/generic/applets/systemtray/package/contents/ui/main.qml f80abc7 =
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
task.h 34aae74 =
plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtray=
task.cpp 6364272 =
plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.h b006967 =
plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.cpp c1bb8b1 =
plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.h c86=
a2d5 =
plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp 4=
257202 =
plasma/generic/applets/systemtray/protocols/fdo/fdotask.h 85a9ec5 =
plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp d1a18df =
plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h 19139=
86 =
plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 761=
a62f =
plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol=
.cpp 505e0c4 =
plasma/generic/applets/systemtray/ui/applet.h bab8d9c =
plasma/generic/applets/systemtray/ui/applet.cpp 41efb10 =
plasma/generic/applets/systemtray/ui/plasmoid.h 01a7c5b =
plasma/generic/applets/systemtray/ui/plasmoid.cpp d3e1937 =
plasma/generic/applets/systemtray/ui/taskspool.h 4b5bcd4 =
plasma/generic/applets/systemtray/ui/taskspool.cpp df39e3d =
plasma/generic/applets/systemtray/ui/uitask.h 7b20bde =
plasma/generic/applets/systemtray/ui/uitask.cpp 2a15800 =
plasma/generic/applets/systemtray/ui/widgetitem.h 40aa92d =
plasma/generic/applets/systemtray/ui/widgetitem.cpp 9d2c622 =
Diff: http://git.reviewboard.kde.org/r/107160/diff/
Testing
-------
Thanks,
Dmitry Ashkadov
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107160/">http://git.reviewboard.kde.org/r/107160/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma, Aaron J. Seigo and Marco Martin.</div>
<div>By Dmitry Ashkadov.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Aaron has noticed in his mail to plasma-devel that the system tray \
requires some refactoring. This is a first step of refactoring. If it is approved \
I'll continue work on system tray.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/CMakeLists.txt <span style="color: \
grey">(d3478a8)</span></li>
<li>plasma/generic/applets/systemtray/core/manager.h <span style="color: \
grey">(3b6b6f8)</span></li>
<li>plasma/generic/applets/systemtray/core/manager.cpp <span style="color: \
grey">(c23225e)</span></li>
<li>plasma/generic/applets/systemtray/core/task.h <span style="color: \
grey">(66bf6e1)</span></li>
<li>plasma/generic/applets/systemtray/core/task.cpp <span style="color: \
grey">(8754785)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/code/main.js <span \
style="color: grey">(10518cd)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/IconsList.qml <span \
style="color: grey">(f251cc5)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/StatusNotifierItem.qml \
<span style="color: grey">(27d476a)</span></li>
<li>plasma/generic/applets/systemtray/package/contents/ui/main.qml <span \
style="color: grey">(f80abc7)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.h \
<span style="color: grey">(34aae74)</span></li>
<li>plasma/generic/applets/systemtray/protocols/dbussystemtray/dbussystemtraytask.cpp \
<span style="color: grey">(6364272)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.h <span \
style="color: grey">(b006967)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdoprotocol.cpp <span \
style="color: grey">(c1bb8b1)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.h <span \
style="color: grey">(c86a2d5)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdoselectionmanager.cpp <span \
style="color: grey">(4257202)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.h <span style="color: \
grey">(85a9ec5)</span></li>
<li>plasma/generic/applets/systemtray/protocols/fdo/fdotask.cpp <span style="color: \
grey">(d1a18df)</span></li>
<li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.h <span \
style="color: grey">(1913986)</span></li>
<li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp <span \
style="color: grey">(761a62f)</span></li>
<li>plasma/generic/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol.cpp \
<span style="color: grey">(505e0c4)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.h <span style="color: \
grey">(bab8d9c)</span></li>
<li>plasma/generic/applets/systemtray/ui/applet.cpp <span style="color: \
grey">(41efb10)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.h <span style="color: \
grey">(01a7c5b)</span></li>
<li>plasma/generic/applets/systemtray/ui/plasmoid.cpp <span style="color: \
grey">(d3e1937)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskspool.h <span style="color: \
grey">(4b5bcd4)</span></li>
<li>plasma/generic/applets/systemtray/ui/taskspool.cpp <span style="color: \
grey">(df39e3d)</span></li>
<li>plasma/generic/applets/systemtray/ui/uitask.h <span style="color: \
grey">(7b20bde)</span></li>
<li>plasma/generic/applets/systemtray/ui/uitask.cpp <span style="color: \
grey">(2a15800)</span></li>
<li>plasma/generic/applets/systemtray/ui/widgetitem.h <span style="color: \
grey">(40aa92d)</span></li>
<li>plasma/generic/applets/systemtray/ui/widgetitem.cpp <span style="color: \
grey">(9d2c622)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107160/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic