[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Review Request: Declarative bindings for ToolBox
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2012-10-31 13:41:53
Message-ID: 20121031134153.11334.32269 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107150/
-----------------------------------------------------------
Review request for Plasma.
Description
-------
This class, which is exposed through the javascript/declarative scriptengin=
e, exposes some properties of AbstractToolBox to the declarative containmen=
t. Specifically, actions, mutability and wether or not its shown (so other =
windows should be hidden).
Diffs
-----
plasma/scriptengines/javascript/CMakeLists.txt fe06582 =
plasma/scriptengines/javascript/declarative/internaltoolbox.h PRE-CREATIO=
N =
plasma/scriptengines/javascript/declarative/internaltoolbox.cpp PRE-CREAT=
ION =
plasma/scriptengines/javascript/plasmoid/appletinterface.h 6fc2d74 =
plasma/scriptengines/javascript/plasmoid/appletinterface.cpp ed5c8ae =
Diff: http://git.reviewboard.kde.org/r/107150/diff/
Testing
-------
Using this with my proof-of-concept desktop containment, seems to work as e=
xpected, for example screen locking changes are picked up as expected.
Thanks,
Sebastian K=C3=BCgler
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107150/">http://git.reviewboard.kde.org/r/107150/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This class, which is exposed through the javascript/declarative \
scriptengine, exposes some properties of AbstractToolBox to the declarative \
containment. Specifically, actions, mutability and wether or not its shown (so other \
windows should be hidden).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Using this with my proof-of-concept desktop containment, seems to work \
as expected, for example screen locking changes are picked up as expected.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/scriptengines/javascript/CMakeLists.txt <span style="color: \
grey">(fe06582)</span></li>
<li>plasma/scriptengines/javascript/declarative/internaltoolbox.h <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/declarative/internaltoolbox.cpp <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletinterface.h <span style="color: \
grey">(6fc2d74)</span></li>
<li>plasma/scriptengines/javascript/plasmoid/appletinterface.cpp <span style="color: \
grey">(ed5c8ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107150/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic