'Re: Review Request: Fix screenChanged signal in javascript appletinterface'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Fix screenChanged signal in javascript appletinterface
From:       "Commit Hook" <null () kde ! org>
Date:       2012-10-25 12:58:46
Message-ID: 20121025125846.11671.17852 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106936/#review20873
-----------------------------------------------------------

This review has been submitted with commit 51398decee51459120d1610e372c3f8d=
c40fe17a by Sebastian K=C3=BCgler to branch KDE/4.9.

- Commit Hook

On Oct. 18, 2012, 1 a.m., Sebastian K=C3=BCgler wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106936/
> -----------------------------------------------------------
> =

> (Updated Oct. 18, 2012, 1 a.m.)
> =

> =

> Review request for Plasma.
> =

> =

> Description
> -------
> =

> Signal/slot signatures were wrong. Correctly forward the screenChanged si=
gnal. This removes the following warning for me when running a QML containm=
ent in plasmoidviewer:
> =

> Object::connect: No such slot ContainmentInterface::screenChanged() in /h=
ome/sebas/kdesvn/src/kde/kde-runtime/plasma/scriptengines/javascript/plasmo=
id/appletinterface.cpp:605
> =

> =

> Diffs
> -----
> =

>   plasma/scriptengines/javascript/plasmoid/appletinterface.cpp f2ccf61 =

> =

> Diff: http://git.reviewboard.kde.org/r/106936/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Sebastian K=C3=BCgler
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106936/">http://git.reviewboard.kde.org/r/106936/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 51398decee51459120d1610e372c3f8dc40fe17a by Sebastian Kügler \
to branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On October 18th, 2012, 1 a.m., Sebastian Kügler wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Sebastian Kügler.</div>

<p style="color: grey;"><i>Updated Oct. 18, 2012, 1 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Signal/slot signatures were wrong. Correctly forward the screenChanged \
signal. This removes the following warning for me when running a QML containment in \
plasmoidviewer:

Object::connect: No such slot ContainmentInterface::screenChanged() in \
/home/sebas/kdesvn/src/kde/kde-runtime/plasma/scriptengines/javascript/plasmoid/appletinterface.cpp:605</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/scriptengines/javascript/plasmoid/appletinterface.cpp <span style="color: \
grey">(f2ccf61)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106936/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 