From kde-panel-devel Thu Oct 25 12:58:46 2012 From: "Commit Hook" Date: Thu, 25 Oct 2012 12:58:46 +0000 To: kde-panel-devel Subject: Re: Review Request: Fix screenChanged signal in javascript appletinterface Message-Id: <20121025125846.11671.17852 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=135116994813487 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4572867657636289932==" --===============4572867657636289932== Content-Type: multipart/alternative; boundary="===============5058771317376757266==" --===============5058771317376757266== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106936/#review20873 ----------------------------------------------------------- This review has been submitted with commit 51398decee51459120d1610e372c3f8d= c40fe17a by Sebastian K=C3=BCgler to branch KDE/4.9. - Commit Hook On Oct. 18, 2012, 1 a.m., Sebastian K=C3=BCgler wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106936/ > ----------------------------------------------------------- > = > (Updated Oct. 18, 2012, 1 a.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Signal/slot signatures were wrong. Correctly forward the screenChanged si= gnal. This removes the following warning for me when running a QML containm= ent in plasmoidviewer: > = > Object::connect: No such slot ContainmentInterface::screenChanged() in /h= ome/sebas/kdesvn/src/kde/kde-runtime/plasma/scriptengines/javascript/plasmo= id/appletinterface.cpp:605 > = > = > Diffs > ----- > = > plasma/scriptengines/javascript/plasmoid/appletinterface.cpp f2ccf61 = > = > Diff: http://git.reviewboard.kde.org/r/106936/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Sebastian K=C3=BCgler > = > --===============5058771317376757266== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106936/

This revie=
w has been submitted with commit 51398decee51459120d1610e372c3f8dc40fe17a b=
y Sebastian K=C3=BCgler to branch KDE/4.9.

- Commit

On October 18th, 2012, 1 a.m., Sebastian K=C3=BCgler wrote:

Review request for Plasma.

By Sebastian K=C3=BCgler.

Updated Oct. 18, 2012, 1 a.m.

Descripti= on

Signal/slot signatures were wrong. Correctly forward the scr=
eenChanged signal. This removes the following warning for me when running a=
 QML containment in plasmoidviewer:

Object::connect: No such slot ContainmentInterface::screenChanged() in /hom=
e/sebas/kdesvn/src/kde/kde-runtime/plasma/scriptengines/javascript/plasmoid=
/appletinterface.cpp:605

Diffs=

plasma/scriptengines/javascript/plasmoid/appletinterface.cpp (f2ccf61)

View Diff

--===============5058771317376757266==-- --===============4572867657636289932== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4572867657636289932==--