[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: Device notifier: show mounted device and path
From: "Aaron J. Seigo" <aseigo () kde ! org>
Date: 2012-10-13 0:33:01
Message-ID: 20121013003301.26133.15023 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Oct. 12, 2012, 1:34 p.m., Sebastian Kügler wrote:
> > Screenshot: Tooltip with mounted device
> > <http://git.reviewboard.kde.org>
> >
> > This tooltip looks really odd and out of place this way.:/
>
> Lamarque Vieira Souza wrote:
> The transparency effect does not look good here. I would like to know how to \
> disable it too, there is this bug against the QML shutdown dialog with the same \
> problem: https://bugs.kde.org/show_bug.cgi?id=303934
303934 is a completely different issue (looks like a compositing manager error).
and i suppose i wasn't clear enough in my previous comments: a patch introducing this \
approach will not be accepted. i have described a more sensible method.
- Aaron J.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106755/#review20224
-----------------------------------------------------------
On Oct. 12, 2012, 9:41 a.m., Jonathan Marten wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106755/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2012, 9:41 a.m.)
>
>
> Review request for KDE Base Apps and Plasma.
>
>
> Description
> -------
>
> If a removable device is mounted using the Plasma device notifier, there is no \
> indication of what the Unix name of the device is or where it is mounted. This \
> information may be useful to the user for (a) accessing the mounted device from \
> non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
> The attached patch shows this information when the device is hovered over, just \
> above the "N actions for this device" text. Depending on whether or not the device \
> is mounted, there are three possibilities that can be shown here:
> /dev/XXX when not mounted
> /dev/XXX mounted on /media/YYYY when mounted
> /dev/XXX mounted if mounted but the mount point is not available
>
> Please be gentle, this is my first QML patch :-)
>
>
> This addresses bug 196939.
> http://bugs.kde.org/show_bug.cgi?id=196939
>
>
> Diffs
> -----
>
> plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml 2a9b3f7
>
> Diff: http://git.reviewboard.kde.org/r/106755/diff/
>
>
> Testing
> -------
>
> Built kde-workspace with this change, observed operation and display of device \
> notifier with a selection of removable devices.
>
> Screenshots
> -----------
>
> Device notifier with mounted device
> http://git.reviewboard.kde.org/r/106755/s/756/
> Tooltip with mounted device
> http://git.reviewboard.kde.org/r/106755/s/769/
>
>
> Thanks,
>
> Jonathan Marten
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106755/">http://git.reviewboard.kde.org/r/106755/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 12th, 2012, 1:34 p.m., <b>Sebastian \
Kügler</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td><a href="http://git.reviewboard.kde.org/r/106755/s/769/" style="color: black; \
font-weight: bold; font-size: 9pt;">196939c.png</a></td> </tr>
<tr>
<td><a href="http://git.reviewboard.kde.org/r/106755/s/769/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/12/196939c_48_66_240_136.png" \
style="border: 1px black solid;" alt="Tooltip with mounted device"></a></td> </tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This tooltip looks \
really odd and out of place this way.:/</pre> </blockquote>
<p>On October 12th, 2012, 1:42 p.m., <b>Lamarque Vieira Souza</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 \
0 1em;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The transparency effect \
does not look good here. I would like to know how to disable it too, there is this \
bug against the QML shutdown dialog with the same problem: \
https://bugs.kde.org/show_bug.cgi?id=303934</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">303934 is a \
completely different issue (looks like a compositing manager error).
and i suppose i wasn't clear enough in my previous comments: a patch introducing \
this approach will not be accepted. i have described a more sensible method.</pre> \
<br />
<p>- Aaron J.</p>
<br />
<p>On October 12th, 2012, 9:41 a.m., Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps and Plasma.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2012, 9:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If a removable device is mounted using the Plasma device notifier, there \
is no indication of what the Unix name of the device is or where it is mounted. This \
information may be useful to the user for (a) accessing the mounted device from \
non-KDE applications, or (b) troubleshooting mounting or unmounting problems.
The attached patch shows this information when the device is hovered over, just above \
the "N actions for this device" text. Depending on whether or not the \
device is mounted, there are three possibilities that can be shown here:
/dev/XXX when not mounted
/dev/XXX mounted on /media/YYYY when mounted
/dev/XXX mounted if mounted but the mount point is not available
Please be gentle, this is my first QML patch :-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Built kde-workspace with this change, observed operation and display of \
device notifier with a selection of removable devices. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=196939">196939</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/devicenotifier/package/contents/ui/DeviceItem.qml <span \
style="color: grey">(2a9b3f7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106755/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/106755/s/756/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/07/196939_400x100.png" \
style="border: 1px black solid;" alt="Device notifier with mounted device" /></a>
<a href="http://git.reviewboard.kde.org/r/106755/s/769/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/10/12/196939c_400x100.png" \
style="border: 1px black solid;" alt="Tooltip with mounted device" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic