'Re: Review Request: Use Product instead of description for device names'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Use Product instead of description for device names
From:       "Jacopo De Simoi" <wilderkde () gmail ! com>
Date:       2012-09-30 14:09:53
Message-ID: 20120930140953.32127.2940 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106637/#review19654
-----------------------------------------------------------

Ship it!

Ship It!

- Jacopo De Simoi

On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106637/
> -----------------------------------------------------------
> =

> (Updated Sept. 29, 2012, 8:21 p.m.)
> =

> =

> Review request for Plasma and Viranch Mehta.
> =

> =

> Description
> -------
> =

> The description is useful for when the device is not hotpluggable/removea=
ble, for example to show:
> 96.3 GiB Hard Drive
> 15.1 GiB Hard Drive
> =

> instead of two identical labels.
> =

> But when it comes to removable/hotpluggable we want to show the Product t=
o be able to show:
> =

> Nokia N9
> Nexus 7
> =

> Instead of =

> Portable Media Player
> Portable Media Player
> =

> The difference can be shown also in the attached screenshots.
> =

> =

> Diffs
> -----
> =

>   plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifie=
r.qml b23df45 =

> =

> Diff: http://git.reviewboard.kde.org/r/106637/diff/
> =

> =

> Testing
> -------
> =

> =

> Screenshots
> -----------
> =

> before
>   http://git.reviewboard.kde.org/r/106637/s/743/
> after
>   http://git.reviewboard.kde.org/r/106637/s/744/
> =

> =

> Thanks,
> =

> Alex Fiestas
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106637/">http://git.reviewboard.kde.org/r/106637/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Jacopo De</p>

<br />
<p>On September 29th, 2012, 8:21 p.m., Alex Fiestas wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma and Viranch Mehta.</div>
<div>By Alex Fiestas.</div>

<p style="color: grey;"><i>Updated Sept. 29, 2012, 8:21 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The description is useful for when the device is not \
hotpluggable/removeable, for example to show: 96.3 GiB Hard Drive
15.1 GiB Hard Drive

instead of two identical labels.

But when it comes to removable/hotpluggable we want to show the Product to be able to \
show:

Nokia N9
Nexus 7

Instead of 
Portable Media Player
Portable Media Player

The difference can be shown also in the attached screenshots.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifier.qml \
<span style="color: grey">(b23df45)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106637/diff/" style="margin-left: \
3em;">View Diff</a></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>

<div>

 <a href="http://git.reviewboard.kde.org/r/106637/s/743/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/descriptions_400x100.png" \
style="border: 1px black solid;" alt="before" /></a>

 <a href="http://git.reviewboard.kde.org/r/106637/s/744/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2012/09/29/product_400x100.png" \
style="border: 1px black solid;" alt="after" /></a>

</div>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 