--===============6458993679970702557== Content-Type: multipart/alternative; boundary="===============7058012446596652193==" --===============7058012446596652193== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106637/#review19654 ----------------------------------------------------------- Ship it! Ship It! - Jacopo De Simoi On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106637/ > ----------------------------------------------------------- > = > (Updated Sept. 29, 2012, 8:21 p.m.) > = > = > Review request for Plasma and Viranch Mehta. > = > = > Description > ------- > = > The description is useful for when the device is not hotpluggable/removea= ble, for example to show: > 96.3 GiB Hard Drive > 15.1 GiB Hard Drive > = > instead of two identical labels. > = > But when it comes to removable/hotpluggable we want to show the Product t= o be able to show: > = > Nokia N9 > Nexus 7 > = > Instead of = > Portable Media Player > Portable Media Player > = > The difference can be shown also in the attached screenshots. > = > = > Diffs > ----- > = > plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifie= r.qml b23df45 = > = > Diff: http://git.reviewboard.kde.org/r/106637/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > before > http://git.reviewboard.kde.org/r/106637/s/743/ > after > http://git.reviewboard.kde.org/r/106637/s/744/ > = > = > Thanks, > = > Alex Fiestas > = > --===============7058012446596652193== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106637/

Ship it!

Ship It!

- Jacopo De

On September 29th, 2012, 8:21 p.m., Alex Fiestas wrote:

Review request for Plasma and Viranch Mehta.

By Alex Fiestas.

Updated Sept. 29, 2012, 8:21 p.m.

Descripti= on

The description is useful for when the device is not hotplug=
gable/removeable, for example to show:
96.3 GiB Hard Drive
15.1 GiB Hard Drive

instead of two identical labels.

But when it comes to removable/hotpluggable we want to show the Product to =
be able to show:

Nokia N9
Nexus 7

Instead of =

Portable Media Player
Portable Media Player

The difference can be shown also in the attached screenshots.

Diffs=

plasma/generic/applets/devicenotifier/package/contents/ui/devicenotifi= er.qml (b23df45)

View Diff

Screensho= ts

--===============7058012446596652193==-- --===============6458993679970702557== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============6458993679970702557==--