[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request: rssnow:Add a Drop a feed here
From: "Giorgos Tsiapaliwkas" <terietor () gmail ! com>
Date: 2012-09-26 15:19:27
Message-ID: 20120926151927.27561.26984 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 19, 2011, 4:53 p.m., Marco Martin wrote:
> > rssnow/package/contents/ui/DropRssEntry.qml, line 25
> > <http://git.reviewboard.kde.org/r/103472/diff/1/?file=43880#file43880line25>
> >
> > DropArea has the drop signal, so
> > onDrop: {
> > print(event.url)
> > }
> >
> > should work
I have solved the issue but I have also added other
stuff. So I will close this review and open a new one
- Giorgos
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103472/#review9086
-----------------------------------------------------------
On Dec. 19, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103472/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2011, 4:28 p.m.)
>
>
> Review request for Plasma.
>
>
> Description
> -------
>
> Hello,
>
> I added the "Drop a feed here", but
> 1.I am still missing the title(look at the screenshot),how can I add one?
> 2.should i make config.ui as the c++ one? (look at the screenshot), and if i make them the same
> how I will connect the signals and slots without c++? I think that the Qt Designer can't do that.
> 3.The "Drop a feed here" doesn't have drag and drop effects.
> I added a DropArea but i don't know if it is correct. I didn't find any onDrop signal,
> so how I will inform the plasmoid about the drop event?
> 4.the ListItemEntry in the main.qml has 3 unknown properties to me link,icon,title, where
> these properties exist?
>
>
> Diffs
> -----
>
> rssnow/package/contents/ui/DropRssEntry.qml e69de29
> rssnow/package/contents/ui/ListItemEntry.qml 657b14b
> rssnow/package/contents/ui/main.qml a575c29
>
> Diff: http://git.reviewboard.kde.org/r/103472/diff/
>
>
> Testing
> -------
>
>
> Screenshots
> -----------
>
>
> http://git.reviewboard.kde.org/r/103472/s/378/
>
>
> Thanks,
>
> Giorgos Tsiapaliwkas
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103472/">http://git.reviewboard.kde.org/r/103472/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 19th, 2011, 4:53 p.m., <b>Marco \
Martin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/103472/diff/1/?file=43880#file43880line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">rssnow/package/contents/ui/DropRssEntry.qml</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">//DragAndDrop.DropArea {</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">DropArea has the drop \
signal, so
onDrop: {
print(event.url)
}
should work</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
solved the issue but I have also added other stuff. So I will close this review and \
open a new one</pre> <br />
<p>- Giorgos</p>
<br />
<p>On December 19th, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Giorgos Tsiapaliwkas.</div>
<p style="color: grey;"><i>Updated Dec. 19, 2011, 4:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Hello,
I added the "Drop a feed here", but
1.I am still missing the title(look at the screenshot),how can I add one?
2.should i make config.ui as the c++ one? (look at the screenshot), and if i make \
them the same how I will connect the signals and slots without c++? I think that the \
Qt Designer can't do that. 3.The "Drop a feed here" doesn't have \
drag and drop effects. I added a DropArea but i don't know if it is correct. I \
didn't find any onDrop signal, so how I will inform the plasmoid about the drop \
event? 4.the ListItemEntry in the main.qml has 3 unknown properties to me \
link,icon,title, where these properties exist?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>rssnow/package/contents/ui/DropRssEntry.qml <span style="color: \
grey">(e69de29)</span></li>
<li>rssnow/package/contents/ui/ListItemEntry.qml <span style="color: \
grey">(657b14b)</span></li>
<li>rssnow/package/contents/ui/main.qml <span style="color: \
grey">(a575c29)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103472/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103472/s/378/"><img \
src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/19/compare_400x100.png" \
style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic