From kde-panel-devel Wed Sep 26 15:19:27 2012 From: "Giorgos Tsiapaliwkas" Date: Wed, 26 Sep 2012 15:19:27 +0000 To: kde-panel-devel Subject: Re: Review Request: rssnow:Add a Drop a feed here Message-Id: <20120926151927.27561.26984 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=134867278118824 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5229820630521871238==" --===============5229820630521871238== Content-Type: multipart/alternative; boundary="===============7666274883477467167==" --===============7666274883477467167== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Dec. 19, 2011, 4:53 p.m., Marco Martin wrote: > > rssnow/package/contents/ui/DropRssEntry.qml, line 25 > > > > > > DropArea has the drop signal, so = > > onDrop: { > > print(event.url) > > } > > = > > should work I have solved the issue but I have also added other stuff. So I will close this review and open a new one - Giorgos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103472/#review9086 ----------------------------------------------------------- On Dec. 19, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103472/ > ----------------------------------------------------------- > = > (Updated Dec. 19, 2011, 4:28 p.m.) > = > = > Review request for Plasma. > = > = > Description > ------- > = > Hello, > = > I added the "Drop a feed here", but = > 1.I am still missing the title(look at the screenshot),how can I add one? > 2.should i make config.ui as the c++ one? (look at the screenshot), and i= f i make them the same > how I will connect the signals and slots without c++? I think that the Qt= Designer can't do that. > 3.The "Drop a feed here" doesn't have drag and drop effects. > I added a DropArea but i don't know if it is correct. I didn't find any o= nDrop signal, > so how I will inform the plasmoid about the drop event? > 4.the ListItemEntry in the main.qml has 3 unknown properties to me link,i= con,title, where > these properties exist? > = > = > Diffs > ----- > = > rssnow/package/contents/ui/DropRssEntry.qml e69de29 = > rssnow/package/contents/ui/ListItemEntry.qml 657b14b = > rssnow/package/contents/ui/main.qml a575c29 = > = > Diff: http://git.reviewboard.kde.org/r/103472/diff/ > = > = > Testing > ------- > = > = > Screenshots > ----------- > = > = > http://git.reviewboard.kde.org/r/103472/s/378/ > = > = > Thanks, > = > Giorgos Tsiapaliwkas > = > --===============7666274883477467167== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/103472/

On December 19th, 2011, 4:53 p.m., Marco Ma= rtin wrote:
= = =
rssnow/package/contents/ui/DropRssEntry.qml (Diff revision 1)
25
//DragAndDrop.DropArea {
DropArea =
has the drop signal, so =

onDrop: {
    print(event.url)
}

should work

I have solved the issue but I have also added other
stuff. So I will close this review and open a new one

- Giorgos

On December 19th, 2011, 4:28 p.m., Giorgos Tsiapaliwkas wrote:

Review request for Plasma.

By Giorgos Tsiapaliwkas.

Updated Dec. 19, 2011, 4:28 p.m.

Descripti= on

Hello,

I added the "Drop a feed here", but =

1.I am still missing the title(look at the screenshot),how can I add one?
2.should i make config.ui as the c++ one? (look at the screenshot), and if =
i make them the same
how I will connect the signals and slots without c++? I think that the Qt D=
esigner can't do that.
3.The "Drop a feed here" doesn't have drag and drop effects.
I added a DropArea but i don't know if it is correct. I didn't find=
 any onDrop signal,
so how I will inform the plasmoid about the drop event?
4.the ListItemEntry in the main.qml has 3 unknown properties to me link,ico=
n,title, where
these properties exist?

Diffs=

rssnow/package/contents/ui/DropRssEntry.qml (657b14b)
rssnow/package/contents/ui/main.qml (a575c= 29)

Screensho= ts

3D""

--===============7666274883477467167==-- --===============5229820630521871238== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============5229820630521871238==--