'Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)
From:       "Albert Astals Cid" <tsdgeos () terra ! es>
Date:       2012-08-31 7:49:35
Message-ID: 20120831074935.4760.17322 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106125/#review18309
-----------------------------------------------------------

This has been commited late for 4.9.1 tagging (6 hours late) and without a shipit \
from anyone in the reviewboard, so I'm not that eager to redo the tarballs. Can \
anyone convince me otherwise? (You have 6 hours for that)

- Albert Astals Cid

On Aug. 26, 2012, 3:52 p.m., Richard Stockton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106125/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2012, 3:52 p.m.)
> 
> 
> Review request for Plasma, Ivan Čukić and Lamarque Vieira Souza.
> 
> 
> Description
> -------
> 
> Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab. This \
> version combines https://git.reviewboard.kde.org/r/104422/ and \
> https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when \
> the feature (RFE bug 276932) is added to 4.9 and Trunk. 
> 
> This addresses bugs 276932 and 297842.
> http://bugs.kde.org/show_bug.cgi?id=276932
> http://bugs.kde.org/show_bug.cgi?id=297842
> 
> 
> Diffs
> -----
> 
> plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 
> plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 
> 
> Diff: http://git.reviewboard.kde.org/r/106125/diff/
> 
> 
> Testing
> -------
> 
> #1 Arrow key movement among programs in the flipscrollview (Right, back to Left, \
> and Up/Down). Activbation of highlighted/selected programs. #2 Search bar entry, \
> movement into View of matches using the Tab key. Move among multiple matching \
> prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the \
> search to be modified; and it is highlighted, allowing the search text to be \
> deleted. #3 an empty search text field re-shows the tab bar and flipscrollview; tab \
> selection is again enabled via left/right arrow keys. 
> NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. \
> Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient \
> knowledge of where you came from, and often tries to send your keystroke to an \
> invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) \
> IS appropriate. 
> But it works.... sort of.
> 
> 
> Thanks,
> 
> Richard Stockton
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106125/">http://git.reviewboard.kde.org/r/106125/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This has been commited \
late for 4.9.1 tagging (6 hours late) and without a shipit from anyone in the \
reviewboard, so I&#39;m not that eager to redo the tarballs. Can anyone convince me \
otherwise? (You have 6 hours for that)</pre>  <br />

<p>- Albert</p>

<br />
<p>On August 26th, 2012, 3:52 p.m., Richard Stockton wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Plasma, Ivan Čukić and Lamarque Vieira Souza.</div>
<div>By Richard Stockton.</div>

<p style="color: grey;"><i>Updated Aug. 26, 2012, 3:52 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Keyboard control of Kickoff-Widget GUI, using arrow keys and \
Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/104422/ and \
https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when the \
feature (RFE bug 276932) is added to 4.9 and Trunk.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">#1 Arrow key movement among programs in the flipscrollview (Right, back \
to Left, and Up/Down). Activbation of highlighted/selected programs. #2 Search bar \
entry, movement into View of matches using the Tab key. Move among multiple matching \
prgrams via arrow keys. Tab goes back to the search TextEdit field, allowing the \
search to be modified; and it is highlighted, allowing the search text to be deleted. \
#3 an empty search text field re-shows the tab bar and flipscrollview; tab selection \
is again enabled via left/right arrow keys.

NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via keyboard. \
Up/Down arrows are sometimes ignored, because the MVC Controller has insufficient \
knowledge of where you came from, and often tries to send your keystroke to an \
invisible, non-responsive View. IMO, Re-design or total replacement (Kickoff-QML) IS \
appropriate.

But it works.... sort of.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=276932">276932</a>, 

 <a href="http://bugs.kde.org/show_bug.cgi?id=297842">297842</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>plasma/desktop/applets/kickoff/ui/launcher.cpp <span style="color: \
grey">(3662ef0)</span></li>

 <li>plasma/desktop/applets/kickoff/ui/searchbar.cpp <span style="color: \
grey">(6937f93)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106125/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 