--===============2677951403423250817== Content-Type: multipart/alternative; boundary="===============5260952124658015530==" --===============5260952124658015530== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106125/#review18309 ----------------------------------------------------------- This has been commited late for 4.9.1 tagging (6 hours late) and without a = shipit from anyone in the reviewboard, so I'm not that eager to redo the ta= rballs. Can anyone convince me otherwise? (You have 6 hours for that) - Albert Astals Cid On Aug. 26, 2012, 3:52 p.m., Richard Stockton wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106125/ > ----------------------------------------------------------- > = > (Updated Aug. 26, 2012, 3:52 p.m.) > = > = > Review request for Plasma, Ivan =C4=8Cuki=C4=87 and Lamarque Vieira Souza. > = > = > Description > ------- > = > Keyboard control of Kickoff-Widget GUI, using arrow keys and Qt::Key_Tab.= This version combines https://git.reviewboard.kde.org/r/104422/ and https:= //git.reviewboard.kde.org/r/106123/, preventing a repeat of bug 297842 when= the feature (RFE bug 276932) is added to 4.9 and Trunk. > = > = > This addresses bugs 276932 and 297842. > http://bugs.kde.org/show_bug.cgi?id=3D276932 > http://bugs.kde.org/show_bug.cgi?id=3D297842 > = > = > Diffs > ----- > = > plasma/desktop/applets/kickoff/ui/launcher.cpp 3662ef0 = > plasma/desktop/applets/kickoff/ui/searchbar.cpp 6937f93 = > = > Diff: http://git.reviewboard.kde.org/r/106125/diff/ > = > = > Testing > ------- > = > #1 Arrow key movement among programs in the flipscrollview (Right, back t= o Left, and Up/Down). Activbation of highlighted/selected programs. > #2 Search bar entry, movement into View of matches using the Tab key. Mov= e among multiple matching prgrams via arrow keys. Tab goes back to the sear= ch TextEdit field, allowing the search to be modified; and it is highlighte= d, allowing the search text to be deleted. > #3 an empty search text field re-shows the tab bar and flipscrollview; ta= b selection is again enabled via left/right arrow keys. > = > NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via = keyboard. Up/Down arrows are sometimes ignored, because the MVC Controller = has insufficient knowledge of where you came from, and often tries to send = your keystroke to an invisible, non-responsive View. IMO, Re-design or tota= l replacement (Kickoff-QML) IS appropriate. > = > But it works.... sort of. > = > = > Thanks, > = > Richard Stockton > = > --===============5260952124658015530== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/106125/ 

This has b=
een commited late for 4.9.1 tagging (6 hours late) and without a shipit fro=
m anyone in the reviewboard, so I'm not that eager to redo the tarballs=
. Can anyone convince me otherwise? (You have 6 hours for that)

- Albert


On August 26th, 2012, 3:52 p.m., Richard Stockton wrote:

Review request for Plasma, Ivan =C4=8Cuki=C4=87 and Lamarque Vieira So= uza.
By Richard Stockton.

Updated Aug. 26, 2012, 3:52 p.m.

Descripti= on 

Keyboard control of Kickoff-Widget GUI, using arrow keys and=
 Qt::Key_Tab. This version combines https://git.reviewboard.kde.org/r/10442=
2/ and https://git.reviewboard.kde.org/r/106123/, preventing a repeat of bu=
g 297842 when the feature (RFE bug 276932) is added to 4.9 and Trunk.

Testing <= /h1> 
#1 Arrow key movement among programs in the flipscrollview (=
Right, back to Left, and Up/Down). Activbation of highlighted/selected prog=
rams.
#2 Search bar entry, movement into View of matches using the Tab key. Move =
among multiple matching prgrams via arrow keys. Tab goes back to the search=
 TextEdit field, allowing the search to be modified; and it is highlighted,=
 allowing the search text to be deleted.
#3 an empty search text field re-shows the tab bar and flipscrollview; tab =
selection is again enabled via left/right arrow keys.

NOTE: It requires 2, even 3 Tabs to get exactly where you want to be via ke=
yboard. Up/Down arrows are sometimes ignored, because the MVC Controller ha=
s insufficient knowledge of where you came from, and often tries to send yo=
ur keystroke to an invisible, non-responsive View. IMO, Re-design or total =
replacement (Kickoff-QML) IS appropriate.

But it works.... sort of.
Bugs: 276932, = 297842

Diffs=

  • plasma/desktop/applets/kickoff/ui/launcher.cpp (3662ef0)
  • plasma/desktop/applets/kickoff/ui/searchbar.cpp (6937f93)

View Diff
--===============5260952124658015530==-- --===============2677951403423250817== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2677951403423250817==--